Make convert a utility method rather than private class member
#4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jloveridge
force-pushed
the
feature/allow-convert-property
branch
from
47daae2 to
b71fa3f
Compare
jloveridge
force-pushed
the
feature/allow-convert-property
branch
from
b71fa3f to
f29f7bf
Compare
jloveridge
changed the title
convert method with __ avoid naming collisionsconvert a utility method rather than private class member
|
Updated to avoid needing to have any private |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I don't particularly like prefixing with
__as a method of hiding private methods I think it best to avoid using any kind of name that might reasonably be expected on an arbitrary object extendingCastable.