Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Implement passkey #2256

Merged
merged 67 commits into from
Nov 1, 2024
Merged

[WIP] Implement passkey #2256

merged 67 commits into from
Nov 1, 2024

Conversation

phuocbitmark
Copy link
Contributor

Description

Describe your changes

  • implement passkeys
  • update onboarding flow

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 24, 2024 •
edited
Loading

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 3 package(s) with unknown licenses.
See the Details below.

License Issues

pubspec.lock

PackageVersionLicenseIssue Type
collection1.18.0NullUnknown License
test_api0.7.2NullUnknown License
test_core0.6.4NullUnknown License

Scanned Manifest Files

pubspec.lock
pubspec.yaml
  • json_annotation@>= 4.9.0, < 5.0.0
  • passkeys@>= 2.0.8, < 3.0.0
  • json_annotation@>= 4.6.0, < 5.0.0

@phuocbitmark phuocbitmark force-pushed the 2989-implement-passkeys branch from 6bdd464 to 6e428b5 Compare October 24, 2024 04:24
@phuocbitmark phuocbitmark force-pushed the 2989-implement-passkeys branch from 880f076 to 2b0c1fe Compare October 25, 2024 09:19
@phuocbitmark
fix finalize
e6623ce 
Signed-off-by: phuoc <[email protected]>
@phuocbitmark
lint
789fe1d 
Signed-off-by: phuoc <[email protected]>
@phuocbitmark
update assets
8915c51 
Signed-off-by: phuoc <[email protected]>
@phuocbitmark
add sentry
c4c43e3 
Signed-off-by: phuoc <[email protected]>
ppupha
ppupha reviewed Oct 28, 2024
View reviewed changes
lib/view/passkey/passkey_login_view.dart Outdated Show resolved Hide resolved
lib/view/passkey/passkey_register_view.dart Outdated Show resolved Hide resolved
lib/view/passkey/passkey_register_view.dart Outdated Show resolved Hide resolved
phuocbitmark and others added 13 commits October 30, 2024 14:02
@phuocbitmark
feedback: remove text
0298953 
Signed-off-by: phuoc <[email protected]>
@phuocbitmark
feedback: loading button
fffc0ea 
Signed-off-by: phuoc <[email protected]>
@phuocbitmark
fix ask face id when open app
1747f8c 
Signed-off-by: phuoc <[email protected]>
@phuocbitmark
delete cache primary address
8231bde 
Signed-off-by: phuoc <[email protected]>
@phuocbitmark
auto login
41c22c1 
Signed-off-by: phuoc <[email protected]>
@phuocbitmark
support anonymous
447badc 
Signed-off-by: phuoc <[email protected]>
@phuocbitmark
reuse customer support anonymous issue id
ebdb5a7 
Signed-off-by: phuoc <[email protected]>
@phuocbitmark
fix user id, text controller dispose, issue order
3c28a76 
Signed-off-by: phuoc <[email protected]>
@phuocbitmark
hide error binding popup
d6b4a0b 
Signed-off-by: phuoc <[email protected]>
@phuocbitmark
fix support authorization header
1890503 
Signed-off-by: phuoc <[email protected]>
@phuocbitmark
fix onboarding loading
a11daf1 
Signed-off-by: phuoc <[email protected]>
@phuocbitmark
Merge pull request #2286 from bitmark-inc/anonymous-support
64ee067 
Anonymous support
@longbmk
Merge branch 'develop' into 2989-implement-passkeys
42276a8
@longbmk longbmk requested a review from ppupha November 1, 2024 04:30
ppupha
ppupha reviewed Nov 1, 2024
View reviewed changes
lib/util/dio_util.dart Outdated Show resolved Hide resolved
@phuocbitmark
fix comment
6be9da8 
Signed-off-by: phuoc <[email protected]>
@phuocbitmark
fix comment
a158021 
Signed-off-by: phuoc <[email protected]>
@longbmk longbmk disabled auto-merge November 1, 2024 05:42
@longbmk longbmk merged commit 7a10ff7 into develop Nov 1, 2024
7 of 8 checks passed
@longbmk longbmk deleted the 2989-implement-passkeys branch November 1, 2024 05:43
github-actions[bot]
github-actions bot reviewed Nov 1, 2024
View reviewed changes
lib/gateway/customer_support_api.g.dart
const _extra = <String, dynamic>{};
final queryParameters = <String, dynamic>{};
final _headers = <String, dynamic>{};
final _headers = <String, dynamic>{r'Authorization': token};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [flutter-analyze] reported by reviewdog 🐶
Unnecessary use of a raw string

lib/gateway/customer_support_api.g.dart
const _extra = <String, dynamic>{};
final queryParameters = <String, dynamic>{};
final _headers = <String, dynamic>{};
final _headers = <String, dynamic>{r'Authorization': token};
_headers.removeWhere((k, v) => v == null);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [flutter-analyze] reported by reviewdog 🐶
Unnecessary duplication of receiver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@ppupha ppupha ppupha approved these changes

@longbmk longbmk Awaiting requested review from longbmk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phuocbitmark @ppupha @longbmk