remove dao #2058
Closed
remove dao #2058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phuocbitmark
force-pushed
the
delete-dao
branch
from
95a4fc0 to
397c29e
Compare
Signed-off-by: phuoc <[email protected]>
Signed-off-by: phuoc <[email protected]>
phuocbitmark
force-pushed
the
delete-dao
branch
from
397c29e to
30ce1bd
Compare
Signed-off-by: phuoc <[email protected]>
phuocbitmark
force-pushed
the
delete-dao
branch
from
30ce1bd to
a398bd3
Compare
Signed-off-by: phuoc <[email protected]>
Signed-off-by: phuoc <[email protected]>
phuocbitmark
force-pushed
the
delete-dao
branch
from
2103618 to
b1d10f6
Compare
ppupha
reviewed
Sep 9, 2024
| if (event.getEth && | ||
| addresses.none( | ||
| (element) => element.cryptoType == CryptoType.ETH.source)) { | ||
| final ethAddress = | ||
| await persona.insertNextAddress(WalletType.Ethereum); | ||
| await _accountService.insertNextAddress(WalletType.Ethereum); |
There was a problem hiding this comment.
i think we should replace persona with walletAddress
ppupha
reviewed
Sep 9, 2024
| @@ -238,24 +216,18 @@ class AccountsBloc extends AuBloc<AccountsEvent, AccountsState> { | |||
|
|
|||
| Future<List<Account>> getAccountPersona( | |||
ppupha
reviewed
Sep 9, 2024
| @@ -84,15 +75,13 @@ class Account { | |||
|
|
|||
| bool get isUsdc => blockchain == 'USDC'; | |||
|
|
|||
| String get className => | |||
| persona != null && walletAddress != null ? 'Persona' : 'Connection'; | |||
| String get className => walletAddress != null ? 'Persona' : 'Connection'; | |||
ppupha
reviewed
Sep 9, 2024
| if (state.personaAddresses?[event.uuid] != null) return; | ||
| final address = await (await _accountService.getPersona(uuid: event.uuid)) | ||
| .wallet() | ||
| if (state.personaAddresses?[event.uuid] != null) { |
ppupha
reviewed
Sep 9, 2024
| if (addresses.isEmpty) { | ||
| final defaultPersona = await accountService.getOrCreateDefaultPersona(); |
There was a problem hiding this comment.
please make sure here we already have primary address
ppupha
reviewed
Sep 9, 2024
| @@ -54,9 +55,11 @@ class _SelectAddressesPageState extends State<SelectAddressesPage> { | |||
| } | |||
|
|
|||
| Future<void> fetchImportedAddresses() async { | |||
| final importedAddresses = await widget.payload.persona.getAddresses(); | |||
| final importedAddresses = await injector<CloudDatabase>() | |||
Signed-off-by: phuoc <[email protected]>
ppupha
reviewed
Sep 9, 2024
| @@ -39,34 +43,16 @@ class AddressService { | |||
| } | |||
| final allEthAddresses = await getAllEthereumAddress(); | |||
| if (allEthAddresses.isEmpty) { | |||
| await deriveAddressesFromAllPersona(); | |||
| await injector<AccountService>().insertAddressAtIndexAndUuid( | |||
There was a problem hiding this comment.
it should derive addresses from all UUIDs
ppupha
reviewed
Sep 9, 2024
| Future<AddressInfo?> getPrimaryAddressInfo() async { | ||
| final addressInfo = await _primaryAddressChannel.getPrimaryAddress(); | ||
| final addressInfo = |
There was a problem hiding this comment.
how about set _primaryAddressInfo to new value?
ppupha
reviewed
Sep 9, 2024
| } | ||
|
|
||
| @override | ||
| Future<Persona> importPersona(String words, String passphrase, | ||
| Future<WalletStorage> importPersona(String words, String passphrase, |
ppupha
reviewed
Sep 9, 2024
| final Persona defaultPersona = await getDefaultPersona(); | ||
| return LibAukDart.getWallet(defaultPersona.uuid); | ||
| final primaryWallet = await getPrimaryWallet(); | ||
| return LibAukDart.getWallet(primaryWallet.uuid); |
There was a problem hiding this comment.
we can use primaryWallet.wallet()
ppupha
reviewed
Sep 9, 2024
| walletAddresses = [ | ||
| await _generateTezosAddressByIndex(uuid, index, name: name), | ||
| ]; | ||
| case WalletType.Autonomy: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe your changes