Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2885/fix issues and feedbacks round 3 #2053

Merged
merged 8 commits into from
Sep 11, 2024
Merged

2885/fix issues and feedbacks round 3 #2053

merged 8 commits into from
Sep 11, 2024

Conversation

hoangbtmrk
Copy link
Contributor

@hoangbtmrk hoangbtmrk commented Sep 4, 2024 •
edited
Loading

Description

Describe your changes

  • Fix UI bugs & feedbacks
    • Membership page:
      • Weird loading after purchasing subscription
      • Remove the blank space at the bottom
      • Center the small mentions below button
      • Update membership icon
    • Update text:
      • Go Premium -> Membership
      • Addresses -> Wallet
  • Created new column C to store D state
  • Fix bug Forget I exist: unawaited delete user API call

@hoangbtmrk hoangbtmrk force-pushed the 2885/fix-issues-and-feedbacks-round-3 branch from 9e43d9d to 325c8b6 Compare September 6, 2024 08:02
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 6, 2024 •
edited
Loading

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 2 package(s) with unknown licenses.
See the Details below.

License Issues

pubspec.lock

PackageVersionLicenseIssue Type
test_api0.7.0NullUnknown License
test_core0.6.0NullUnknown License

Scanned Manifest Files

pubspec.lock

github-actions[bot]
github-actions bot reviewed Sep 6, 2024
View reviewed changes
pubspec.lock Show resolved Hide resolved
pubspec.lock Show resolved Hide resolved
pubspec.lock Show resolved Hide resolved
pubspec.lock Show resolved Hide resolved
pubspec.lock Show resolved Hide resolved
pubspec.lock Show resolved Hide resolved
pubspec.lock Show resolved Hide resolved
pubspec.lock Show resolved Hide resolved
pubspec.lock Show resolved Hide resolved
pubspec.lock Show resolved Hide resolved
@hoangbtmrk hoangbtmrk requested a review from ppupha September 9, 2024 02:31
@hoangbtmrk hoangbtmrk force-pushed the 2885/fix-issues-and-feedbacks-round-3 branch from 325c8b6 to 8750920 Compare September 9, 2024 02:31
@hoangbtmrk hoangbtmrk force-pushed the 2885/fix-issues-and-feedbacks-round-3 branch from 8750920 to a75c2a6 Compare September 11, 2024 02:41
@hoangbtmrk hoangbtmrk force-pushed the 2885/fix-issues-and-feedbacks-round-3 branch from a75c2a6 to 4ad8868 Compare September 11, 2024 14:20
@hoangbtmrk hoangbtmrk merged commit 32a9c70 into develop Sep 11, 2024
6 of 8 checks passed
@hoangbtmrk hoangbtmrk deleted the 2885/fix-issues-and-feedbacks-round-3 branch September 11, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@ppupha ppupha ppupha approved these changes

@phuocbitmark phuocbitmark Awaiting requested review from phuocbitmark

@anhnguyenbitmark anhnguyenbitmark Awaiting requested review from anhnguyenbitmark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hoangbtmrk @ppupha