Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: encript env, decrypt when app run #1600

Merged
merged 11 commits into from
Mar 29, 2024
Merged

Conversation

phuocbitmark
Copy link
Contributor

Description

Describe your changes

  • Added a function A to process data B
  • Created new column C to store D state
  • Refactor workflow E to improve performance because of F

Copy link
Contributor

github-actions bot commented Mar 26, 2024

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

pubspec.lock
pubspec.yaml
  • cryptography@>= 2.7.0, < 3.0.0
  • cryptography_flutter@>= 2.3.2, < 3.0.0

@phuocbitmark phuocbitmark changed the title fix: encript env, decrypt when app run [WIP] fix: encript env, decrypt when app run Mar 26, 2024
Copy link
Contributor

@hvthhien hvthhien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • suggest spitting secrets into a new file.
  • I feel decrypting and storing all the values in a variable when app startup is not a best practice, I think we should encrypt for each value, only decrypt and get the value when needed.

Signed-off-by: phuoc <[email protected]>
Copy link
Contributor

@hvthhien hvthhien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • should update the Readme.md, add instruction steps to set up the secret env locally.
  • since we have multiples files for the script, suggest moving these files into a script folder.

Signed-off-by: phuoc <[email protected]>
@phuocbitmark phuocbitmark requested a review from hvthhien March 28, 2024 07:29
script/encrypt_secrets.sh Outdated Show resolved Hide resolved
@hvthhien hvthhien changed the title [WIP] fix: encript env, decrypt when app run fix: encript env, decrypt when app run Mar 29, 2024
Signed-off-by: phuoc <[email protected]>
@phuocbitmark phuocbitmark merged commit f1576d5 into security_audit Mar 29, 2024
7 of 8 checks passed
@phuocbitmark phuocbitmark deleted the encrypt_env_secret branch March 29, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants