-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: encript env, decrypt when app run #1600
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: phuoc <[email protected]>
Dependency Review✅ No vulnerabilities or license issues found.Scanned Manifest Filespubspec.yaml
|
phuocbitmark
changed the title
fix: encript env, decrypt when app run
[WIP] fix: encript env, decrypt when app run
Mar 26, 2024
Signed-off-by: phuoc <[email protected]>
Signed-off-by: phuoc <[email protected]>
Signed-off-by: phuoc <[email protected]>
hvthhien
suggested changes
Mar 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- suggest spitting secrets into a new file.
- I feel decrypting and storing all the values in a variable when app startup is not a best practice, I think we should encrypt for each value, only decrypt and get the value when needed.
Signed-off-by: phuoc <[email protected]>
hvthhien
suggested changes
Mar 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- should update the
Readme.md
, add instruction steps to set up the secret env locally. - since we have multiples files for the script, suggest moving these files into a script folder.
Signed-off-by: phuoc <[email protected]>
hvthhien
reviewed
Mar 28, 2024
Signed-off-by: phuoc <[email protected]>
hvthhien
reviewed
Mar 29, 2024
Signed-off-by: phuoc <[email protected]>
hvthhien
changed the title
[WIP] fix: encript env, decrypt when app run
fix: encript env, decrypt when app run
Mar 29, 2024
Signed-off-by: phuoc <[email protected]>
hvthhien
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe your changes