[WIP]Backup: use firestore #1396
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppupha
force-pushed
the
Sang/backup/use_fireStore
branch
from
4ce6951 to
e7937a6
Compare
ppupha
force-pushed
the
Sang/backup/use_fireStore
branch
from
e7937a6 to
5288a3c
Compare
Dependency Review✅ No vulnerabilities or license issues found.Scanned Manifest Filespubspec.lockpubspec.yaml
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ppupha
commented
Jan 30, 2024
| unawaited(injector<MetricClientService>() | ||
| .mixPanelClient | ||
| .initIfDefaultAccount()); | ||
| // unawaited(injector<MetricClientService>() |
There was a problem hiding this comment.
TODO: remove this commented lines.
ppupha
commented
Jan 30, 2024
| @@ -350,15 +352,18 @@ class _ClaimActivationPageState extends State<ClaimActivationPage> { | |||
| _processing = false; | |||
| }); | |||
| if (mounted) { | |||
| Navigator.of(context).pushNamedAndRemoveUntil( | |||
| await Navigator.of(context).pushNamedAndRemoveUntil( | |||
There was a problem hiding this comment.
TODO: fix remove await.
| @@ -7,14 +7,20 @@ | |||
|
|
|||
| // ignore_for_file: unawaited_futures, type_annotate_public_apis | |||
|
|
|||
| // ignore_for_file: unawaited_futures | |||
There was a problem hiding this comment.
The diagnostic 'unawaited_futures' doesn't need to be ignored here because it's already being ignored
| @@ -349,15 +351,18 @@ class _ClaimActivationPageState extends State<ClaimActivationPage> { | |||
| _processing = false; | |||
| }); | |||
| if (mounted) { | |||
| Navigator.of(context).pushNamedAndRemoveUntil( | |||
| await Navigator.of(context).pushNamedAndRemoveUntil( | |||
There was a problem hiding this comment.
📝 [flutter-analyze] reported by reviewdog 🐶
Don't use 'BuildContext's across async gaps, guarded by an unrelated 'mounted' check
| if (!mounted) { | ||
| return; | ||
| } | ||
| await Navigator.of(context).pushNamed(AppRouter.artworkDetailsPage, |
There was a problem hiding this comment.
📝 [flutter-analyze] reported by reviewdog 🐶
Don't use 'BuildContext's across async gaps, guarded by an unrelated 'mounted' check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe your changes