Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix)API: Correctly pass scheduled job proxy env vars when launching jobs #237

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

mgonnav
Copy link
Contributor

@mgonnav mgonnav commented Nov 30, 2023

Description

  • In the launch_job task called by scheduled jobs to launch jobs, we were not adding the env vars related to the proxy provider selected for the scheduled job.
  • In this PR we:
    • Fix scheduled jobs not passing proxy env vars correctly to jobs
    • Refactor the logic to add the corresponding proxy provider env vars
    • Format code

Issue

Checklist before requesting a review

  • I have performed a self-review of my code.
  • My code follows the style guidelines of this project.
  • I have made corresponding changes to the documentation.
  • New and existing tests pass locally with my changes.
  • If this change is a core feature, I have added thorough tests.
  • If this change affects or depends on the behavior of other estela repositories, I have created pull requests with the relevant changes in the affected repositories. Please, refer to our official documentation.
  • I understand that my pull request may be closed if it becomes obvious or I did not perform all of the steps above.

@mgonnav mgonnav requested a review from joaquingx November 30, 2023 17:42
@mgonnav mgonnav self-assigned this Nov 30, 2023
Copy link
Contributor

@joaquingx joaquingx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgonnav mgonnav merged commit 26cd034 into main Nov 30, 2023
@mgonnav mgonnav deleted the BITMAKER-4178 branch November 30, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants