Add support to jruby #10
Open
+53
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sorry, test are failing. it may be a good idea to add jruby to the test matrix. also, can you squash these commits? |
ivanxuu
force-pushed
the
master
branch
3 times, most recently
from
c8149f7 to
3b26977
Compare
To be used this gem in jRuby we will be using activerecord-jdbcpostgresql-adapter or maybe another adapter like activerecord-postgis-adapter. They all both support hstore because they run over postgres anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using this gem in a jRuby proyect. The problem is that in the
.gemspecthe 'pg' gem is required, but in jruby you probably will be using 'activerecord-jdbcpostgresql-adapter' instead.. But in the end its the same postgres db backend with the same hstore support.