Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for 5.x planned changes #247 #271

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BeauBouchard
Copy link

Description

Completes most if not all the work for #247

@BeauBouchard
Copy link
Author

BeauBouchard commented Dec 29, 2021

@bithavoc Happy Holidays and New Year.

I am willing to complete the work for the remainder of #247 although i see there is CI/CD issues with new PRs.

I am proposing #272 which the main intent is just for CI to be working again and also make it more accessible for future developer contributions.
Edit:
I did the refactor of the CI and recommend merging this PR: #274
Before this one, as it will make your CI working again after merging.

* whitelist
* blacklist
* allowlist
* denylist

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this instance it is referencing the previous terms so this should not be replaced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants