Merge pull request #212 from golopot/eslint

Add eslint and fix lint errors

.eslintrc

@@ -0,0 +1,21 @@
+{
+  "extends": ["eslint:recommended"],
+  "env": {
+    "es6": true,
+    "node": true
+  },
+  "parserOptions": {
+    "ecmaVersion": 6
+  },
+  "rules": {
+    "no-unused-vars": [2, { "args": "none" }]
+  },
+  "overrides": [
+    {
+      "files": "test/**",
+      "env": {
+        "mocha": true
+      }
+    }
+  ]
+}

index.js

@@ -98,7 +98,7 @@ function filterObject(originalObj, whiteList, initialFilter) {
         if(typeof (value) !== 'undefined') {
             obj[propName] = value;
             fieldsSet = true;
-        };
+        }
     });
 
     return fieldsSet?obj:undefined;
@@ -249,7 +249,7 @@ exports.logger = function logger(options) {
     return function (req, res, next) {
         var coloredRes = {};
 
-        var currentUrl = req.originalUrl || req.url;
+        var currentUrl = req.originalUrl || req.url;
         if (currentUrl && _.includes(options.ignoredRoutes, currentUrl)) return next();
         if (options.ignoreRoute(req, res)) return next();
 
@@ -273,7 +273,7 @@ exports.logger = function logger(options) {
             res.end = end;
             res.end(chunk, encoding);
 
-            req.url = req.originalUrl || req.url;
+            req.url = req.originalUrl || req.url;
 
             var meta = {};
 

package.json

@@ -28,13 +28,15 @@
   },
   "main": "index.js",
   "scripts": {
-    "test": "nyc mocha && nyc report --reporter lcov"
+    "pretest": "eslint .",
+    "test": "node_modules/.bin/mocha --reporter spec"
   },
   "dependencies": {
     "chalk": "^2.4.1",
     "lodash": "^4.17.10"
   },
   "devDependencies": {
+    "eslint": "^5.16.0",
     "mocha": "^5.2.0",
     "node-mocks-http": "^1.5.1",
     "nyc": "^14.1.1",

test/test.js

@@ -1,9 +1,6 @@
-var util = require('util');
-
 var mocks = require('node-mocks-http');
 var should = require('should');
 var _ = require('lodash');
-var winston = require('winston');
 var Transport = require('winston-transport');
 
 var expressWinston = require('../index.js');
@@ -264,11 +261,6 @@ describe('express-winston', function () {
         return errorLoggerTestHelper(testHelperOptionsWithBlacklist).then(function (result) {
           result.log.meta.should.not.have.property('trace');
         });
-
-        var testHelperOptionsWithoutBlacklist = { loggerOptions: {} };
-        return errorLoggerTestHelper(testHelperOptionsWithoutBlacklist).then(function (result) {
-          result.log.meta.should.have.property('trace');
-        });
       });
     });
 
@@ -676,7 +668,7 @@ describe('express-winston', function () {
 
     describe('when middleware function is invoked on a route that returns JSON', function() {
       it('should parse JSON in response body', function() {
-        var bodyObject = { "message": "Hi!  I\'m a chunk!" };
+        var bodyObject = { "message": "Hi!  I'm a chunk!" };
         function next(req, res, next) {
           // Set Content-Type in a couple different case types, just in case.
           // Seems like the mock response doesn't quite handle the case