Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prerelease v-9.1.2-pre-01 (#9533) #9534

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

msynk
Copy link
Member

@msynk msynk commented Dec 23, 2024

closes #9533

Summary by CodeRabbit

  • New Features

    • Updated version for multiple packages and modules to 9.1.2-pre-01, indicating new features or improvements.
  • Bug Fixes

    • Enhanced stability of the application with updated package references.
  • Documentation

    • Updated version comments in service worker files and project templates to reflect the new version.
  • Chores

    • Adjusted project files to ensure consistency across various components with the new versioning scheme.

@msynk msynk requested a review from ysmoradi December 23, 2024 17:31
Copy link

coderabbitai bot commented Dec 23, 2024

Walkthrough

This pull request involves a comprehensive version update across multiple projects and components from version 9.1.1 to 9.1.2-pre-01. The changes primarily focus on updating version numbers in various configuration files, JavaScript/TypeScript scripts, and project files. The update appears to be a coordinated pre-release version increment, touching multiple repositories and demo projects within the Bit ecosystem.

Changes

File Path Change Summary
src/Bit.Build.props Version updated from 9.1.1 to 9.1.2-pre-01
src/Besql/Bit.Besql/wwwroot/bit-besql.js Version updated from 9.1.1 to 9.1.2-pre-01
src/BlazorUI/Bit.BlazorUI/Scripts/general.ts Version updated from 9.1.1 to 9.1.2-pre-01
Multiple Demo and Template Project Files Package references updated to 9.1.2-pre-01
Service Worker Files Version comment updated to 9.1.2-pre-01

Assessment against linked issues

Objective Addressed Explanation
Prerelease v-9.1.2-pre-01

Poem

🐰 Hop, hop, version update's here!
A pre-release whisper, crystal clear
From 9.1.1 to 9.1.2-pre-01
CodeRabbit's magic has just begun
Version bumps dance with glee! 🎉


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 50b292e and 39845a9.

📒 Files selected for processing (43)
  • src/Besql/Bit.Besql/wwwroot/bit-besql.js (1 hunks)
  • src/Bit.Build.props (1 hunks)
  • src/BlazorUI/Bit.BlazorUI/Scripts/general.ts (1 hunks)
  • src/BlazorUI/Demo/Bit.BlazorUI.Demo.Server/Bit.BlazorUI.Demo.Server.csproj (1 hunks)
  • src/BlazorUI/Demo/Bit.BlazorUI.Demo.Shared/Bit.BlazorUI.Demo.Shared.csproj (1 hunks)
  • src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Bit.BlazorUI.Demo.Client.Core.csproj (1 hunks)
  • src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Maui/Bit.BlazorUI.Demo.Client.Maui.csproj (1 hunks)
  • src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Web/Bit.BlazorUI.Demo.Client.Web.csproj (1 hunks)
  • src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Web/wwwroot/service-worker.published.js (1 hunks)
  • src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Windows/Bit.BlazorUI.Demo.Client.Windows.csproj (1 hunks)
  • src/BlazorUI/Demo/Directory.Build.props (1 hunks)
  • src/Bswup/Bit.Bswup.Demo/wwwroot/service-worker.js (1 hunks)
  • src/Bswup/Bit.Bswup.Demo/wwwroot/service-worker.published.js (1 hunks)
  • src/Bswup/Bit.Bswup.NewDemo/Bit.Bswup.NewDemo.Client/wwwroot/service-worker.js (1 hunks)
  • src/Bswup/Bit.Bswup.NewDemo/Bit.Bswup.NewDemo.Client/wwwroot/service-worker.published.js (1 hunks)
  • src/Bswup/Bit.Bswup/Scripts/bit-bswup.progress.ts (1 hunks)
  • src/Bswup/Bit.Bswup/Scripts/bit-bswup.sw.ts (1 hunks)
  • src/Bswup/Bit.Bswup/Scripts/bit-bswup.ts (1 hunks)
  • src/Bswup/FullDemo/Client/wwwroot/service-worker.js (1 hunks)
  • src/Bswup/FullDemo/Client/wwwroot/service-worker.published.js (1 hunks)
  • src/Bup/Bit.Bup/Scripts/bit-bup.progress.ts (1 hunks)
  • src/Bup/Bit.Bup/Scripts/bit-bup.ts (1 hunks)
  • src/Butil/Bit.Butil/Scripts/butil.ts (1 hunks)
  • src/Templates/BlazorEmpty/Bit.BlazorEmpty/BlazorEmpty.Client/BlazorEmpty.Client.csproj (2 hunks)
  • src/Templates/BlazorEmpty/Bit.BlazorEmpty/BlazorEmpty/BlazorEmpty.csproj (2 hunks)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Web/wwwroot/service-worker.published.js (1 hunks)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Build.props (1 hunks)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages.props (2 hunks)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages8.props (2 hunks)
  • src/Websites/Careers/src/Bit.Websites.Careers.Client/Bit.Websites.Careers.Client.csproj (1 hunks)
  • src/Websites/Careers/src/Bit.Websites.Careers.Server/Bit.Websites.Careers.Server.csproj (1 hunks)
  • src/Websites/Careers/src/Bit.Websites.Careers.Shared/Bit.Websites.Careers.Shared.csproj (1 hunks)
  • src/Websites/Careers/src/Directory.Build.props (1 hunks)
  • src/Websites/Platform/src/Bit.Websites.Platform.Client/Bit.Websites.Platform.Client.csproj (1 hunks)
  • src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Templates/Templates03GettingStartedPage.razor (1 hunks)
  • src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Templates/Templates03GettingStartedPage.razor.cs (1 hunks)
  • src/Websites/Platform/src/Bit.Websites.Platform.Server/Bit.Websites.Platform.Server.csproj (1 hunks)
  • src/Websites/Platform/src/Bit.Websites.Platform.Shared/Bit.Websites.Platform.Shared.csproj (1 hunks)
  • src/Websites/Platform/src/Directory.Build.props (1 hunks)
  • src/Websites/Sales/src/Bit.Websites.Sales.Client/Bit.Websites.Sales.Client.csproj (1 hunks)
  • src/Websites/Sales/src/Bit.Websites.Sales.Server/Bit.Websites.Sales.Server.csproj (1 hunks)
  • src/Websites/Sales/src/Bit.Websites.Sales.Shared/Bit.Websites.Sales.Shared.csproj (1 hunks)
  • src/Websites/Sales/src/Directory.Build.props (1 hunks)
✅ Files skipped from review due to trivial changes (26)
  • src/Bswup/Bit.Bswup.Demo/wwwroot/service-worker.js
  • src/Websites/Careers/src/Directory.Build.props
  • src/Websites/Sales/src/Directory.Build.props
  • src/Bswup/Bit.Bswup.NewDemo/Bit.Bswup.NewDemo.Client/wwwroot/service-worker.js
  • src/Butil/Bit.Butil/Scripts/butil.ts
  • src/Bup/Bit.Bup/Scripts/bit-bup.ts
  • src/Bswup/Bit.Bswup.Demo/wwwroot/service-worker.published.js
  • src/Bswup/Bit.Bswup.NewDemo/Bit.Bswup.NewDemo.Client/wwwroot/service-worker.published.js
  • src/Besql/Bit.Besql/wwwroot/bit-besql.js
  • src/BlazorUI/Demo/Bit.BlazorUI.Demo.Server/Bit.BlazorUI.Demo.Server.csproj
  • src/Templates/BlazorEmpty/Bit.BlazorEmpty/BlazorEmpty.Client/BlazorEmpty.Client.csproj
  • src/Bswup/Bit.Bswup/Scripts/bit-bswup.ts
  • src/Websites/Careers/src/Bit.Websites.Careers.Shared/Bit.Websites.Careers.Shared.csproj
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Web/wwwroot/service-worker.published.js
  • src/Bup/Bit.Bup/Scripts/bit-bup.progress.ts
  • src/Bswup/Bit.Bswup/Scripts/bit-bswup.progress.ts
  • src/BlazorUI/Demo/Directory.Build.props
  • src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Web/wwwroot/service-worker.published.js
  • src/Websites/Sales/src/Bit.Websites.Sales.Shared/Bit.Websites.Sales.Shared.csproj
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Build.props
  • src/Websites/Platform/src/Directory.Build.props
  • src/Bswup/FullDemo/Client/wwwroot/service-worker.js
  • src/Bswup/Bit.Bswup/Scripts/bit-bswup.sw.ts
  • src/Bswup/FullDemo/Client/wwwroot/service-worker.published.js
  • src/BlazorUI/Bit.BlazorUI/Scripts/general.ts
  • src/Templates/BlazorEmpty/Bit.BlazorEmpty/BlazorEmpty/BlazorEmpty.csproj
🔇 Additional comments (21)
src/Bit.Build.props (1)

30-30: Looks good – version increment is consistent.
Updating the ReleaseVersion to "9.1.2-pre-01" is aligned with the PR’s objective. No functional issues noted. Ensure release notes and documentation are updated accordingly.

src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Templates/Templates03GettingStartedPage.razor.cs (1)

41-41: Ensure template version usage is up-to-date across docs and readme.
The updated install command referencing "Bit.Boilerplate::9.1.2-pre-01" is correct for the new pre-release. Please verify any documentation that references the old version.

✅ Verification successful

Let me search for any documentation files that might reference template versions.


Let me search specifically for version references in documentation files.


Version 9.1.2-pre-01 is consistently referenced across documentation

The version "9.1.2-pre-01" is consistently used in all relevant places:

  • Templates03GettingStartedPage.razor: <a href="https://www.nuget.org/packages/Bit.Boilerplate/9.1.2-pre-01">
  • Templates03GettingStartedPage.razor: <CodeBox>dotnet new install Bit.Boilerplate::9.1.2-pre-01</CodeBox>
  • Templates03GettingStartedPage.razor.cs: command:"dotnet new install Bit.Boilerplate::9.1.2-pre-01;"
🏁 Scripts executed

The following scripts were executed for the analysis:

Error: No shell scripts found


Script:

#!/bin/bash
# Search for files that might contain documentation or version references
fd -e md -e txt README
rg -i "bit.boilerplate" --type=md --type=txt -C2

Length of output: 2489


Script:

#!/bin/bash
# Search for version numbers and install commands in documentation
rg -i "dotnet new install" -C2
rg -i "::9\.1\." -C2

Length of output: 4511

src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages8.props (1)

4-11: Centralized version bump for multiple Bit. packages.*
All package references have been cleanly updated from "9.1.1" to "9.1.2-pre-01". This aligns well with the overall versioning strategy. Check if any third-party dependency or readme references need a similar update.

Also applies to: 49-49

src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages.props (1)

4-11: Consistent versioning approach across the board.
The increment to "9.1.2-pre-01" maintains consistency and helps avoid mismatched dependencies. Confirm that your pipeline and release scripts also reference the correct version for these packages.

Also applies to: 49-49

src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Templates/Templates03GettingStartedPage.razor (1)

177-178: Version synchronization is correct.
The version bump from 9.1.1 to 9.1.2-pre-01 appears consistent with the rest of the PR changes. Ensure that any references in documentation or scripts are updated accordingly to prevent mismatched dependencies.

src/Websites/Platform/src/Bit.Websites.Platform.Shared/Bit.Websites.Platform.Shared.csproj (1)

9-13: Coordinated version upgrade verified.
The changes to Bit.CodeAnalyzers and Bit.SourceGenerators versions from 9.1.1 to 9.1.2-pre-01 are in line with updates across the repository, ensuring consistency.

src/BlazorUI/Demo/Bit.BlazorUI.Demo.Shared/Bit.BlazorUI.Demo.Shared.csproj (1)

8-12: Consistent package upgrade detected.
Updating both Bit.CodeAnalyzers and Bit.SourceGenerators to 9.1.2-pre-01 maintains alignment with the pre-release version across files.

src/Websites/Sales/src/Bit.Websites.Sales.Server/Bit.Websites.Sales.Server.csproj (1)

13-17: Version updates aligned.
The version increments for Bit.CodeAnalyzers and Bit.SourceGenerators are consistent with the unified version scheme in the project.

src/Websites/Careers/src/Bit.Websites.Careers.Server/Bit.Websites.Careers.Server.csproj (1)

13-20: LGTM: Version updates are consistent

The version updates for Bit.CodeAnalyzers and Bit.SourceGenerators to 9.1.2-pre-01 are consistent with the pre-release version bump. Package configurations are properly maintained.

src/Websites/Platform/src/Bit.Websites.Platform.Server/Bit.Websites.Platform.Server.csproj (1)

13-20: LGTM: Consistent version updates

Version updates match the pattern seen in other project files, maintaining consistency across the solution.

src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Web/Bit.BlazorUI.Demo.Client.Web.csproj (1)

27-36: LGTM: Version updates are consistent with pre-release

The version updates for Bit.Bswup, Bit.CodeAnalyzers, and Bit.SourceGenerators to 9.1.2-pre-01 maintain consistency across the solution.

Since this is a Blazor WebAssembly application, let's verify if there are any breaking changes in the pre-release that might affect WASM compatibility:

✅ Verification successful

Let me gather more information about any potential breaking changes in the pre-release version.


LGTM: Version updates are safe for WASM compatibility

The project is properly configured as a Blazor WebAssembly application with appropriate WASM-specific settings including lazy loading, AOT optimization (WasmStripILAfterAOT), and PWA support. The version updates are consistent, and the addition of Bit.Bswup package aligns with the project's WASM architecture. The project maintains essential WASM configurations and optimizations that are compatible with the pre-release version.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check for any WASM-specific changes or breaking changes in recent commits

# Search for WASM-related changes in recent commits
git log --grep="wasm" --grep="webassembly" -i --since="1 month ago"

# Look for any WASM-specific configurations or breaking changes
rg -i "wasm|webassembly" --type md

Length of output: 1690


Script:

#!/bin/bash
# Check for any breaking changes or major updates in changelog/release notes
rg -i "breaking|major|upgrade" CHANGELOG.md

# Check for any WASM-specific configurations in the project
rg -i "blazor.webassembly" src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Web/

# Look for any WASM-specific dependencies or configurations in the project file
cat src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Web/Bit.BlazorUI.Demo.Client.Web.csproj

Length of output: 3049

src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Windows/Bit.BlazorUI.Demo.Client.Windows.csproj (1)

32-39: LGTM: Package version updates are consistent

The development-time dependencies have been correctly updated to version 9.1.2-pre-01, maintaining version consistency across the project.

src/Websites/Sales/src/Bit.Websites.Sales.Client/Bit.Websites.Sales.Client.csproj (2)

25-36: LGTM: Package version updates are consistent

All Bit.* packages have been correctly updated to version 9.1.2-pre-01, maintaining version consistency across the project.


Line range hint 20-23: Verify configuration loading with embedded appsettings.json

The change from Content to EmbeddedResource for appsettings.json might affect how configuration is loaded at runtime. Please ensure:

  1. The application correctly loads configuration from embedded resources
  2. This change is consistent with other projects in the solution
✅ Verification successful

Configuration change is consistent with other client projects

The change from Content to EmbeddedResource for appsettings.json is consistent with other client projects in the solution. The same pattern is used in:

  • Bit.BlazorUI.Demo.Client.Core
  • Bit.Websites.Careers.Client
  • Bit.Websites.Platform.Client
  • Bit.Websites.Sales.Client

Additionally, Boilerplate.Shared uses an even more comprehensive setup for embedded appsettings. This is a common and valid approach for Blazor client projects to handle configuration files.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check if other projects have similar configuration for appsettings.json
fd -e csproj | xargs grep -l "appsettings.json"

Length of output: 479


Script:

#!/bin/bash
# Check how appsettings.json is configured in other projects
for proj in $(fd -e csproj); do
  echo "=== $proj ==="
  grep -A 2 -B 2 "appsettings.json" "$proj" || true
done

Length of output: 17537

src/Websites/Careers/src/Bit.Websites.Careers.Client/Bit.Websites.Careers.Client.csproj (1)

25-36: LGTM: Package version updates and configuration changes are consistent

The changes mirror those in Bit.Websites.Sales.Client.csproj:

  1. All Bit.* packages updated to version 9.1.2-pre-01
  2. Configuration file handling changes are consistent across projects
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Bit.BlazorUI.Demo.Client.Core.csproj (2)

19-23: LGTM: Version updates align with prerelease v9.1.2-pre-01

The package references for Bit.CodeAnalyzers and Bit.SourceGenerators have been correctly updated to version 9.1.2-pre-01.


Line range hint 12-16: Resource handling changes look good

Moving compilerconfig.json to None and appsettings.json to EmbeddedResource aligns with the standardization of resource handling across the project.

src/Websites/Platform/src/Bit.Websites.Platform.Client/Bit.Websites.Platform.Client.csproj (2)

25-36: LGTM: Consistent version updates across all Bit packages

All Bit package references have been correctly updated to version 9.1.2-pre-01, maintaining consistency across the project.


Line range hint 19-22: Resource handling standardization looks good

The changes to resource handling (compilerconfig.json and appsettings.json) follow the same pattern as other projects, ensuring consistency.

src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Maui/Bit.BlazorUI.Demo.Client.Maui.csproj (2)

88-95: LGTM: Version updates and configuration changes look good

Package references for Bit.CodeAnalyzers and Bit.SourceGenerators have been correctly updated to version 9.1.2-pre-01. The removal of launchSettings.json from Content is appropriate.


Line range hint 3-24: Verify MAUI platform configurations

The MAUI-specific configurations for different platforms (Android, iOS, MacCatalyst) remain unchanged, which is correct as this PR focuses on version updates.

✅ Verification successful

MAUI platform configurations are correctly maintained

The verification confirms that:

  • No platform-specific files in the Platforms directory were modified
  • The only changes in the project file are package version updates
  • The target frameworks and platform configurations remain unchanged and properly configured for Android, iOS, MacCatalyst, and Windows (conditionally)
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Verify that no other MAUI configuration files were modified in this PR
git diff --name-only HEAD~1 | grep -E "Platforms/(Android|iOS|MacCatalyst)/"

Length of output: 78


Script:

#!/bin/bash
# Let's first check if the Platforms directory exists and its structure
fd -t d "Platforms"

# Then check for any platform-specific files in the entire repository
fd -e plist -e xml -e gradle -e properties -e pbxproj

Length of output: 2895


Script:

#!/bin/bash
# Let's check if any of these platform-specific files were modified in this PR
git diff --name-only HEAD~1 | grep -E "src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Maui/Platforms/"

# Also check the content changes in the project file
git diff HEAD~1 src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Maui/Bit.BlazorUI.Demo.Client.Maui.csproj

Length of output: 1461


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@msynk msynk merged commit 867e2b3 into bitfoundation:develop Dec 23, 2024
3 checks passed
@msynk msynk deleted the 9533-prerelease-v-9.1.2-pre-01 branch December 23, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prerelease v-9.1.2-pre-01
2 participants