feat(blazorui): add missing dispose process to BitPdfReader #9647 (#9661

)
bitfoundation · Jan 11, 2025 · 8d6a51c · 8d6a51c
1 parent 3fcb9d3
commit 8d6a51c
Show file tree

Hide file tree

Showing 3 changed files with 41 additions and 20 deletions.
diff --git a/src/BlazorUI/Bit.BlazorUI.Extras/Components/PdfReader/BitPdfReader.razor.cs b/src/BlazorUI/Bit.BlazorUI.Extras/Components/PdfReader/BitPdfReader.razor.cs
@@ -5,7 +5,7 @@ namespace Bit.BlazorUI;
 /// <summary>
 /// BitPdfReader is a simple pdf renderer utilizing the pdfjs library to bring pdf reading feature into Blazor world.
 /// </summary>
-public partial class BitPdfReader
+public partial class BitPdfReader : IAsyncDisposable
 {
     private bool _allPageRendered;
     private int _numberOfPages = 1;
@@ -36,7 +36,7 @@ public partial class BitPdfReader
     /// <summary>
     /// The configuration of the pdf reader (<see cref="BitPdfReaderConfig"/>).
     /// </summary>
-    [Parameter] public BitPdfReaderConfig Config { get; set; }
+    [Parameter] public BitPdfReaderConfig Config { get; set; } = new();
 
     /// <summary>
     /// Renders the pages horizontally.
@@ -69,6 +69,7 @@ public partial class BitPdfReader
     [Parameter] public string? Style { get; set; }
 
 
+
     /// <summary>
     /// Re-renders the provided page number or the current page.
     /// </summary>
@@ -174,9 +175,9 @@ protected override async Task OnAfterRenderAsync(bool firstRender)
                 "_content/Bit.BlazorUI.Extras/pdf.js/pdfjs-4.7.76-worker.js"
             ];
 
-            await _js.BitPdfReaderInitPdfJs(scripts);
+            await _js.BitPdfReaderInit(scripts);
 
-            _numberOfPages = await _js.BitPdfReaderSetupPdfDoc(Config);
+            _numberOfPages = await _js.BitPdfReaderSetup(Config);
 
             await OnPdfLoaded.InvokeAsync();
 
@@ -243,4 +244,11 @@ private async Task RefreshAllPages()
 
         await OnPdfPageRendered.InvokeAsync();
     }
+
+
+
+    public async ValueTask DisposeAsync()
+    {
+        await _js.BitPdfReaderDispose(Config.Id);
+    }
 }
diff --git a/src/BlazorUI/Bit.BlazorUI.Extras/Components/PdfReader/BitPdfReader.ts b/src/BlazorUI/Bit.BlazorUI.Extras/Components/PdfReader/BitPdfReader.ts
@@ -1,17 +1,3 @@
-declare type PdfJsLib = {
-    getDocument: (src?: string | URL | TypedArray | ArrayBuffer | DocumentInitParameters) => PDFDocumentLoadingTask;
-    GlobalWorkerOptions: GlobalWorkerOptions
-}
-
-declare type BitPdfReaderConfig = {
-    id: string;
-    url: string;
-    scale: number;
-    autoScale: boolean;
-    pdfDoc?: PDFDocumentProxy;
-    isRendering: boolean[];
-}
-
 namespace BitBlazorUI {
     export class PdfReader {
         private static _initPromise?: Promise<unknown>;
@@ -116,5 +102,27 @@ namespace BitBlazorUI {
                 config.isRendering[pageNumber] = false;
             }
         }
+
+        public static dispose(id: string) {
+            const config = PdfReader._bitPdfReaders.get(id);
+            if (!config) return;
+
+            config.pdfDoc?.destroy();
+            PdfReader._bitPdfReaders.delete(id);
+        }
     }
+}
+
+declare type PdfJsLib = {
+    getDocument: (src?: string | URL | TypedArray | ArrayBuffer | DocumentInitParameters) => PDFDocumentLoadingTask;
+    GlobalWorkerOptions: GlobalWorkerOptions
+}
+
+declare type BitPdfReaderConfig = {
+    id: string;
+    url: string;
+    scale: number;
+    autoScale: boolean;
+    pdfDoc?: PDFDocumentProxy;
+    isRendering: boolean[];
 }
diff --git a/src/BlazorUI/Bit.BlazorUI.Extras/Components/PdfReader/BitPdfReaderJsRuntimeExtensions.cs b/src/BlazorUI/Bit.BlazorUI.Extras/Components/PdfReader/BitPdfReaderJsRuntimeExtensions.cs
@@ -2,12 +2,12 @@
 
 internal static class BitPdfReaderJsRuntimeExtensions
 {
-    public static ValueTask BitPdfReaderInitPdfJs(this IJSRuntime jsRuntime, IEnumerable<string> scripts)
+    public static ValueTask BitPdfReaderInit(this IJSRuntime jsRuntime, IEnumerable<string> scripts)
     {
         return jsRuntime.InvokeVoidAsync("BitBlazorUI.PdfReader.init", scripts);
     }
 
-    public static ValueTask<int> BitPdfReaderSetupPdfDoc(this IJSRuntime jsRuntime, BitPdfReaderConfig config)
+    public static ValueTask<int> BitPdfReaderSetup(this IJSRuntime jsRuntime, BitPdfReaderConfig config)
     {
         return jsRuntime.InvokeAsync<int>("BitBlazorUI.PdfReader.setup", config);
     }
@@ -21,4 +21,9 @@ public static ValueTask BitPdfReaderRefreshPage(this IJSRuntime jsRuntime, BitPd
     {
         return jsRuntime.InvokeVoidAsync("BitBlazorUI.PdfReader.refreshPage", config, pageNumber);
     }
+
+    public static ValueTask BitPdfReaderDispose(this IJSRuntime jsRuntime, string id)
+    {
+        return jsRuntime.InvokeVoidAsync("BitBlazorUI.PdfReader.dispose", id);
+    }
 }