Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to compose state and kotlin flows - 1. iteration #279

Merged
merged 13 commits into from
Apr 15, 2024
Merged

Switch to compose state and kotlin flows - 1. iteration #279

merged 13 commits into from
Apr 15, 2024

Conversation

ArnyminerZ
Copy link
Member

@ArnyminerZ ArnyminerZ commented Apr 10, 2024 •
edited
Loading

I've added a test for Settings, though if you don't find it necessary we can get rid of it.

@ArnyminerZ
Added forceDarkModeFlow
9c72c4b 
Signed-off-by: Arnau Mora Gras <[email protected]>
@ArnyminerZ
Deprecated method
27e5ddc 
Signed-off-by: Arnau Mora Gras <[email protected]>
@ArnyminerZ
Added test
3a43a44 
Signed-off-by: Arnau Mora Gras <[email protected]>
@ArnyminerZ
Added comments
16daa55 
Signed-off-by: Arnau Mora Gras <[email protected]>
@ArnyminerZ ArnyminerZ self-assigned this Apr 10, 2024
@ArnyminerZ ArnyminerZ linked an issue Apr 10, 2024 that may be closed by this pull request
Switch to compose state and kotlin flows - 1. iteration #267
Closed
3 tasks
@ArnyminerZ
Migrated to flow
f793a1b 
Signed-off-by: Arnau Mora Gras <[email protected]>
@ArnyminerZ
Migrated to flow
083aad9 
Signed-off-by: Arnau Mora Gras <[email protected]>
@ArnyminerZ
Fixed deprecations
1467287 
Signed-off-by: Arnau Mora Gras <[email protected]>
@ArnyminerZ ArnyminerZ marked this pull request as ready for review April 10, 2024 11:47
@ArnyminerZ ArnyminerZ requested a review from sunkup April 10, 2024 11:47
sunkup
sunkup requested changes Apr 10, 2024
View reviewed changes
Copy link
Member

@sunkup sunkup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please go ahead and make the functions suspendable :)

@ArnyminerZ
Made all functions suspending
8e36066 
Signed-off-by: Arnau Mora Gras <[email protected]>
@ArnyminerZ
Fixed suspending calls
32f7923 
Signed-off-by: Arnau Mora Gras <[email protected]>
@ArnyminerZ
Made callbacks suspending
2ee5726 
Signed-off-by: Arnau Mora Gras <[email protected]>
@ArnyminerZ ArnyminerZ requested a review from sunkup April 10, 2024 12:53
ArnyminerZ and others added 3 commits April 10, 2024 14:56
sunkup
sunkup approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@sunkup sunkup left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. More tests are always good 👍
I just removed the data.close() calls. It says in the Kdoc, they don't do anything for InputStream.

I would like to try my hands on some of the new flow concepts as well with the 2. iteration, if that's okay with you?

@ArnyminerZ
Copy link
Member Author

Yup, let's merge this one and you can work on 2

@sunkup sunkup merged commit ff34782 into dev Apr 15, 2024
7 checks passed
@sunkup sunkup deleted the 267-switch-to-compose-state-and-kotlin-flows-1-iteration branch April 15, 2024 06:27
sunkup added a commit that referenced this pull request Apr 15, 2024
@sunkup
Revert "Switch to compose state and kotlin flows - 1. iteration (#279)"
4a56898 
This reverts commit ff34782.
@sunkup sunkup mentioned this pull request Apr 15, 2024
Merged
ArnyminerZ pushed a commit that referenced this pull request Apr 15, 2024
@sunkup
Revert "Switch to compose state and kotlin flows - 1. iteration (#279)…
bc2adbc 
…" (#285)

This reverts commit ff34782.
@sunkup sunkup restored the 267-switch-to-compose-state-and-kotlin-flows-1-iteration branch April 17, 2024 09:53
sunkup added a commit that referenced this pull request Apr 17, 2024
@sunkup
Revert "Revert "Switch to compose state and kotlin flows - 1. iterati…
ed8665a 
…on (#279…"

This reverts commit bc2adbc.
sunkup added a commit that referenced this pull request Apr 17, 2024
@sunkup
Revert "Switch to compose state and kotlin flows - 1. iteration (#279)…
ea88798 
…" (#285)

This reverts commit ff34782.
sunkup added a commit that referenced this pull request Apr 18, 2024
@sunkup
Revert "Revert "Switch to compose state and kotlin flows - 1. iterati…
12d47c0 
…on (#279…" (#288)

This reverts commit bc2adbc.
This was referenced Apr 18, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunkup sunkup sunkup approved these changes

Assignees

@ArnyminerZ ArnyminerZ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch to compose state and kotlin flows - 1. iteration
2 participants
@ArnyminerZ @sunkup