-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI overhaul for setup view #274
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks and works great. The only thing that I'd add, now that we are into it, is displaying a more "user friendly" name when we pick a file.
I have this snippet for example:
String[] projection = {MediaStore.MediaColumns.DISPLAY_NAME};
Cursor metaCursor = cr.query(uri, projection, null, null, null);
if (metaCursor != null) {
try {
if (metaCursor.moveToFirst()) {
fileName = metaCursor.getString(0);
}
} finally {
metaCursor.close();
}
}
I think it would be much better than directly showing content://...
However, if you think the current implementation is enough, I can work with it 😄
Nice idea. I have added it now. I would have liked to compute the filename from the url in the viewmodel, but we'd need to pass context or content resolver which is discouraged. This will become cleaner once we use Kotlin flows and compose state anyways, I guess. |
# Conflicts: # app/src/main/java/at/bitfire/icsdroid/ui/views/EnterUrlComposable.kt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just merged with the main branch, everything seems to work fine.
You can merge if it looks good to you
More or less what @devvv4ever created as a Mockup.
What do you think? @ArnyminerZ