Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EPROD-552] Migrate from ethers-core to alloy #208

Merged
merged 88 commits into from
Dec 12, 2024
Merged

[EPROD-552] Migrate from ethers-core to alloy #208

merged 88 commits into from
Dec 12, 2024

Conversation

ufoscout
Copy link
Contributor

@ufoscout ufoscout commented Nov 23, 2024 •
edited
Loading

Issue ticket

Issue ticket link:
https://infinityswap.atlassian.net/browse/EPROD-552

Checklist before requesting a review

Code conventions

  • I have performed a self-review of my code
  • Every new function is documented
  • Object names are auto explicative

Security

  • The PR does not break APIs backward compatibility
  • The PR does not break the stable storage backward compatibility

Testing

  • Every function is properly unit tested
  • I have added integration tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • IC endpoints are always tested through the canister_call! macro

@ufoscout
migrate did to alloy -> part 1
b074259
@ufoscout
migrate did to alloy -> part 2
d76c561
@ufoscout
migrate did to alloy -> part 3
49a01b0
@ufoscout
migrate did to alloy -> part 4
eb6bb9c
@ufoscout
migrate did to alloy -> part 5
5350bf1
@ufoscout
migrate did to alloy -> part 6
6e6e31b
@ufoscout
migrate did to alloy -> part 7
9c2c20a
@ufoscout
migrate did to alloy -> part 8
19aa310
@ufoscout
migrate did to alloy -> part 9
3c4fffa
@ufoscout
migrate did to alloy -> part 10
c042513
@ufoscout
migrate did to alloy -> part 11
dcdcc3e
@ufoscout
migrate did to alloy -> part 12
472e3ed
@ufoscout
migrate did to alloy -> part 13 - All did tests pass
958e67e
@ufoscout
migrate did to alloy -> part 13
8013430
@ufoscout
migrate did to alloy -> part 14
f81583f
@ufoscout
migrate did to alloy -> part 15
15abaaa
@ufoscout
migrate did to alloy -> part 16
1faa9bc
@ufoscout
migrate did to alloy -> part 17 - eth-signer-alloy compiles
5367a70
@ufoscout
migrate did to alloy -> part 18
cfadd86
@ufoscout
migrate did to alloy -> part 19
c9b4f4c
@ufoscout
migrate did to alloy -> part 20
f0bd12e
@ufoscout
migrate did to alloy -> part 21 - signer compiles
dc06c76
@ufoscout
migrate did to alloy -> part 22
14780e1
@ufoscout
migrate did to alloy -> part 23
bc62011
@ufoscout
migrate did to alloy -> part 24
5826d8d
@ufoscout
migrate did to alloy -> part 25
d5e518b
@ufoscout
migrate did to alloy -> part 26
a240d7d
@ufoscout
remove_old_signer
0cfb8d5
@ufoscout
migrate did to alloy -> part 27
a3a3b71
@ufoscout
migrate did to alloy -> part 28
05de8a3
@ufoscout ufoscout marked this pull request as ready for review December 6, 2024 10:50
@ufoscout ufoscout changed the title Alloy [EPROD-552] Migrate from ethers-core to alloy Dec 6, 2024
Maximkaaa
Maximkaaa requested changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@Maximkaaa Maximkaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some mechanical review. I didn't actually check yet what those changes would imply for EVM or Bridges....

src/did/src/block.rs Outdated Show resolved Hide resolved
src/did/src/block.rs Show resolved Hide resolved
src/did/src/block.rs Outdated Show resolved Hide resolved
src/did/src/integer.rs Show resolved Hide resolved
src/did/src/integer.rs Show resolved Hide resolved
src/did/src/transaction.rs Outdated Show resolved Hide resolved
src/eth-signer/src/sign_strategy.rs Outdated Show resolved Hide resolved
src/eth-signer/src/sign_strategy.rs Outdated Show resolved Hide resolved
src/eth-signer/src/sign_strategy.rs Outdated Show resolved Hide resolved
src/eth-signer/src/transaction.rs Outdated Show resolved Hide resolved
@ufoscout ufoscout requested a review from Maximkaaa December 10, 2024 14:13
@ufoscout ufoscout merged commit 27316a2 into main Dec 12, 2024
3 checks passed
@ufoscout ufoscout deleted the alloy branch December 12, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@F3kilo F3kilo F3kilo approved these changes

@veeso veeso veeso approved these changes

@Maximkaaa Maximkaaa Maximkaaa approved these changes

@itsyaasir itsyaasir Awaiting requested review from itsyaasir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ufoscout @Maximkaaa @veeso @F3kilo