New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py39 + black + typing + typehints #61

Merged

bitcraft merged 1 commit into bitcraft:master from JaskRendix:py39

Jan 17, 2024

Contributor

JaskRendix commented Jan 17, 2024 •

edited

Loading

PR:

bumps to python 3.9;
blacks everything (ln88);
replaces List with list, Dict with dict, etc.;
moves Sequence, etc into collections.abc;
gets rid of some typehints: 382 > 316 (mostly missing returns, the most evident -> None, there are others, but it's a first step)

In the #59 I went further, but it's better to take baby steps.

JaskRendix force-pushed the py39 branch from c4f14c2 to beddc32 Compare

January 17, 2024 12:19


          py39

8af1678

JaskRendix force-pushed the py39 branch from beddc32 to 8af1678 Compare

January 17, 2024 13:01

JaskRendix changed the title ~~py39~~ py39 + black + typing + typehints

Owner

bitcraft commented Jan 17, 2024

thanks for the cleanup, looks great

bitcraft merged commit 988c436 into bitcraft:master

4 checks passed

JaskRendix deleted the py39 branch

January 17, 2024 18:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet