New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyproject.toml + isort #60

Merged

bitcraft merged 1 commit into bitcraft:master from JaskRendix:toml

Jan 15, 2024

Contributor

JaskRendix commented Jan 14, 2024 •

edited

Loading

PR:

gets rid of setup() and implements pyproject.toml;
updates workflows actions checkout and setup-python (last version);
isort everything;

regarding toml I'm unsure about:

[tool.setuptools]
include-package-data = true

[tool.setuptools.packages.find]
where = ["."]
include = ["pyscroll*"]

because I adapted to this line in setup() package_data={"pyscroll": ["license.txt", "readme.md"]}, but we could do )I think) simply:

[tool.setuptools]
packages = ["pyscroll"]


          toml

02df9b3

JaskRendix mentioned this pull request

Closed

Owner

bitcraft commented Jan 15, 2024

thanks for cleaning it up. looks great

bitcraft merged commit dae50ec into bitcraft:master

3 checks passed

JaskRendix deleted the toml branch

January 16, 2024 12:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet