Added support to handle custom async finalizers #1972
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Included in this PR are some quality of life updates to Typescript types, preferring to optional keys for finalScriptSig/finalScriptWitness so that users don't have to explicitly specify undefined for unused key. |
|
I'd be interested to hear a concrete use case. Signing is obvious, with HSMs and separate signing devices requiring user input. Finalizing seems like it lacks the need for async IO with some outside service / device... |
|
Actually, I agree, will close out now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently you can only use synchronous custom finalizers when finalizing an input - it would be greatly useful to also support async finalizers as well. This PR is an attempt to implement that as simply as possible. Any feedback is greatly welcome :)