Merge pull request #11 from bitcoinerlab/fix/throttling-infinite-loop

Ensure throttling is disabled after final task to prevent infinite loops

package.json

@@ -2,7 +2,7 @@
   "name": "@bitcoinerlab/explorer",
   "description": "Bitcoin Blockchain Explorer: Client Interface featuring Esplora and Electrum Implementations.",
   "homepage": "https://github.com/bitcoinerlab/explorer",
-  "version": "0.3.0",
+  "version": "0.3.1",
   "author": "Jose-Luis Landabaso",
   "license": "MIT",
   "prettier": "@bitcoinerlab/configs/prettierConfig.json",

src/requestQueue.ts

@@ -181,12 +181,24 @@ export class RequestQueue {
             hardErrorAttempts >= this.maxAttemptsForHardErrors - 1
           ) {
             this.concurrentTasks--;
+            //Fetch failed. Now this error must be rethrown.
+            //Befor that, if this was the last task, disable throttling after
+            //unthrottleAfterTime to prevent an infinite loop in the while() on
+            //the next call. See below: while(mustThrottle === true)...
+            if (this.concurrentTasks === 0) {
+              if (this.unthrottleTimeout) clearTimeout(this.unthrottleTimeout);
+              this.unthrottleTimeout = setTimeout(() => {
+                this.mustThrottle = false;
+                this.unthrottleTimeout = undefined;
+              }, this.unthrottleAfterTime);
+            }
             console.warn(
               `Max attempts reached soft ${softErrorAttempts + 1} / hard ${
                 hardErrorAttempts + 1
               } - rethrowing error. Consider reducing rate limits and/or increasing maxAttemptsForSoftErrors & maxAttemptsForSoftErrors.`
             );
-            throw error; //not going to try again - rethrow original error
+            //Not going to try again - rethrow original error
+            throw error;
           } else {
             softErrorAttempts++;
             hardErrorAttempts++;