Merge pull request #13 from bitcoinerlab/mempool-blockheight-0

fix: use 0 for mempool blockheight accross all implementations
bitcoinerlab · Sep 20, 2024 · 471f760 · 471f760
2 parents 9c18d03 + 9057f53
commit 471f760
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -2,7 +2,7 @@
   "name": "@bitcoinerlab/explorer",
   "description": "Bitcoin Blockchain Explorer: Client Interface featuring Esplora and Electrum Implementations.",
   "homepage": "https://github.com/bitcoinerlab/explorer",
-  "version": "0.3.2",
+  "version": "0.3.3",
   "author": "Jose-Luis Landabaso",
   "license": "MIT",
   "prettier": "@bitcoinerlab/configs/prettierConfig.json",

diff --git a/src/electrum.ts b/src/electrum.ts
@@ -416,7 +416,10 @@ export class ElectrumExplorer implements Explorer {
 
     const transactionHistory = history.map(({ tx_hash, height }) => {
       const txId = tx_hash;
-      const blockHeight: number = height || 0;
+      //Electrum returns -1 for mempool, however we use blockHeight = 0 to
+      //denote mempool
+      const blockHeight: number =
+        parseInt(height) === -1 ? 0 : parseInt(height);
       if (blockHeight > this.#tipBlockHeight) {
         console.warn(
           `tx ${tx_hash} block height ${blockHeight} larger than the tip ${this.#tipBlockHeight}`