chore: upgrade and bump some CI dependencies #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleonardolima
force-pushed
the
chore/upgrade-and-bump-ci
branch
from
150b86a to
bcb66e6
Compare
Pull Request Test Coverage Report for Build 10657465976Details
💛 - Coveralls |
3 tasks
|
Concept ACK, overall this looks like the right thing to do. Just need to add |
oleonardolima
force-pushed
the
chore/upgrade-and-bump-ci
branch
from
32dd561 to
18e459b
Compare
- rename the workflow from Rust to CI - add name to build-test step of Build & Test
refactor(ci)!: add new `fmt` and `clippy` jobs - adds two new jobs for `fmt` and `clippy`. - use `dtolnay/rust-toolchain@v1` instead of `actions-rs/toolchain@v1` chore(rustfmt): add `.rustfmt.toml` and use `nighly on fmt CI step
- bumps the `edition` on `Cargo.toml` to `2021. - add `.clippy.toml` with `msrv=1.63.0` file.
oleonardolima
force-pushed
the
chore/upgrade-and-bump-ci
branch
from
18e459b to
1a4d5cf
Compare
notmandatory
added a commit
that referenced
this pull request
Sep 25, 2024
…ntation improvements 1103936 chore(style+docs): style and docs retouch (Leonardo Lima) 442789c chore(style): update new methods style (Leonardo Lima) 565d79e refactor(async): add common GET and POST methods (Leonardo Lima) 31dfa4b chore(docs): minor improvements on docstrings (Leonardo Lima) Pull request description: <!-- You can erase any parts of this template not applicable to your Pull Request. --> ### Description It builds on top of #95. Applies minor improvements on some docstrings, and Cargo.toml standard. The main change is adding the common HTTP methods for the `AsyncClient`, it removes duplicated code from each Esplora API request, and follows the approach done for `BlockingClient`. It makes it easier to extract these methods into an `AsyncEsploraClient` trait (to be done in another PR, initially done here 9cbc387), which the user can implement with any HTTP client of its choice. Also, makes it simpler to rebase and update the `AsyncAnonymizedClient` from #67. <!-- Describe the purpose of this PR, what's being adding and/or fixed --> ### Notes to the reviewers It has some commits from #95, as it builds on top of it and should be merged afterward. Please let me know what you think about the proposed changes and approach. <!-- In this section you can include notes directed to the reviewers, like explaining why some parts of the PR were done in a specific way --> ### Changelog notice - Applies minor improvements on documentation. - Add common `get_response` and `post_request` methods to `AsyncClient`, previously duplicated through the esplora API calls. It follows the approach done for `BlockinClient`. <!-- Notice the release manager should include in the release tag message changelog --> <!-- See https://keepachangelog.com/en/1.0.0/ for examples --> ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [x] I ran `cargo fmt` and `cargo clippy` before committing ACKs for top commit: ValuedMammal: ACK 1103936 notmandatory: ACK 1103936 Tree-SHA512: 5579e0cba105f553782e419a16c26fc75b38a2ab8ee523f5ce5e2b9a4560503ef7f81faac546429851802efb66cf125cb36b49f20f088969a6ad580e644d43e5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does some improvements on CI, these are some changes that I ended up doing on other refactoring and feature PRs (making them too convoluted), but had a specific CI scope so I'm moving them to a specific PR.
This PR does:
actions/checkout@v3toactions/checkout@v4.fmtandclippy(clippy has been moved to a specific job).fmtproblems.2021..clippy.tomlfile withmsrv=1.63.0.Notes to the reviewers
I hope this PR reduces the scope convolution from the other ones #67 #93, and makes the review easier.
Changelog notice
actions/checkout@v3toactions/checkout@v4.fmtandclippy(clippy has been moved to a specific job).fmtproblems.2021..clippy.tomlfile withmsrv=1.63.0.Checklists
All Submissions:
cargo fmtandcargo clippybefore committing