Make Address Clone

[DanGould]

The lack of this derive seems to be an oversight.

Having this clone makes it more ergonomic to use Address as a dependency binding downstream

[evanlinjin]

ACK a298c61

[tnull]

LGTM

Seems simple enough and indeed like an oversight.

That said, @DanGould I'm not fully sure I understand why you need this in the Payjoin FFI API. Out of interest, mind pointing me towards an example that requires it?

[DanGould]

I want to require an Arc<bitcoin_ffi::Address> parameter to a UniFFI function which ultimately passes bitcoin_ffi::Address out of the arc to a general FFI function used for both flutter bindings and uniffi, but to get bitcoin_ffi::Address from Arc::unwrap_or_clone bitcoin_ffi::Address needs to be Clone:

impl Receiver {
    /// Creates a new `SessionInitializer` with the provided parameters.
    ///
    /// # Parameters
    /// - `address`: The Bitcoin address for the payjoin session.
    /// - `network`: The network to use for address verification.
    /// - `directory`: The URL of the store-and-forward payjoin directory.
    /// - `ohttp_keys`: The OHTTP keys used for encrypting and decrypting HTTP requests and responses.
    /// - `ohttp_relay`: The URL of the OHTTP relay, used to keep client IP address confidential.
    /// - `expire_after`: The duration in seconds after which the session expires.
    ///
    /// # Returns
    /// A new instance of `SessionInitializer`.
    ///
    /// # References
    /// - [BIP 77: Payjoin Version 2: Serverless Payjoin](https://github.com/bitcoin/bips/pull/1483)
    #[uniffi::constructor]
    pub fn new(
        address: Arc<Address>,
        directory: Arc<Url>,
        ohttp_keys: Arc<OhttpKeys>,
        ohttp_relay: Arc<Url>,
        expire_after: Option<u64>,
    ) -> Result<Self, PayjoinError> {
        // TODO Arc::try_unwrap(address).unwrap_or_else(|arc| (*arc).clone()) once bitcoin-ffi makes Address Clone
        super::Receiver::new(
            Arc::try_unwrap(address).unwrap_or_else(|arc| (*arc).clone()),
            (*directory).clone(),
            (*ohttp_keys).clone(),
            (*ohttp_relay).clone(),
            expire_after,
        )
        .map(Into::into)
    }
// ...
}