-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug-fix] Set the db sync height #726
Conversation
79759c8
to
42a0587
Compare
Updated with review comments.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
42a0587
to
b8ce842
Compare
Thanks @vladimirfomene for the catches.. Updated.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK b8ce842
fdf1f5c
to
a72a97b
Compare
Thanks @afilini for the look.. Updated as suggested.. In the last dev call we talked about releasing this as a patch version for some downstream libs to update.. See bitcoindevkit/bdk-cli#102 (comment) |
Sorry I didn't notice the two issues that Alekos has found, I should have inspected the code better. re-utACK a72a97b |
@rajarshimaitra even though we talked about doing a fix release for this, since this is a test framework fix and code freeze for 0.22 is next Wed. (Aug 31), can we skip doing a fix release only for this PR and wait for 0.22 to put it out (Sept 7)? |
@notmandatory sounds good to me.. Only needed for the bdk-cli PR.. That can wait a bit.. |
Previously we weren't setting the db sync height in populate_test_db macro even when current height is provided.. This creates a bug that get_funded_wallet will return 0 balance. This PR fixes the populate_test_db macro and updates tests which were previously dependent on the unsynced wallet behavior.
a72a97b
to
08668ac
Compare
Updated and rebased.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 08668ac
Description
Fixes #719
Previously we weren't setting the db sync height in populate_test_db
macro even when current height is provided.. This creates a bug that
get_funded_wallet will return 0 balance.
This PR fixes the populate_test_db macro and updates tests which were
previously dependent on the unsynced wallet behavior.
Notes to the reviewers
Checklists
All Submissions:
cargo fmt
andcargo clippy
before committingBugfixes: