-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature(testenv)/run regtest tests in series #1728
Feature(testenv)/run regtest tests in series #1728
Conversation
9c33c3d
to
9a48794
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though it's under dev-dependencies
and being used exclusively for tests, I'm not entirely sure if we do need this one. Are there any major improvements that it adds to the tests?
@oleonardolima this is so tests work with |
should we update rustc version? https://github.com/bitcoindevkit/bdk/actions/runs/11896104128/job/33175482146?pr=1728 I can just downgrade serial_test for now update: setting serial_test = { version = "=3.0.0" } to remove scc dep which requires rustc 1.65 |
9a48794
to
a8e1095
Compare
hmm, looks like 3.0.0 also has a dep on 1.65 (build failed again https://github.com/bitcoindevkit/bdk/actions/runs/11924661651/job/33299306353?pr=1728) |
a8e1095
to
7caa75f
Compare
7caa75f
to
391452a
Compare
As mentioned on the issue I'm not on board with serializing all tests. This is probably something better to just document as a caveat for MacOS users so we can still by default run tests in parallel for linux users (and CI). |
@notmandatory ok, I was wondering if it would effect performance. I was thinking maybe linux ran in series by default or something and that's why we're only seeing this on mac. I'll close this and we can just document the issue in the other pr |
Description
This PR is a proposed solution to #1723
It enforces running tests that use bitcoind or electrsd in series (rather than parallel)
Notes to the reviewers
Originally I had suggested just including a test troubleshooting section in docs to show ways to run in series
Bugfixes: