Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require &Wallet to build light client #87

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

rustaceanrob
Copy link
Collaborator

@rustaceanrob rustaceanrob commented Dec 13, 2024

Would allow for future builds that create a node for multiple wallets.

Copy link
Collaborator

@ValuedMammal ValuedMammal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b3162ed

@@ -61,20 +61,18 @@ const RECOMMENDED_PEERS: u8 = 2;

#[derive(Debug)]
/// Construct a light client from a [`Wallet`] reference.
pub struct LightClientBuilder<'a> {
wallet: &'a Wallet,
pub struct LightClientBuilder {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think LightClientBuilder can just derive Default now.

@rustaceanrob rustaceanrob merged commit 8c26de3 into bitcoindevkit:master Dec 16, 2024
2 checks passed
@rustaceanrob rustaceanrob deleted the builder-12-13 branch December 16, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants