Add WalletExt to extend Wallet for ease-of-use
#83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustaceanrob
force-pushed
the
wallet-ext-12-12
branch
2 times, most recently
from
a703c49 to
3b72535
Compare
rustaceanrob
changed the title
RelevantScripts to extend Wallet for ease-of-useWalletExt to extend Wallet for ease-of-use
rustaceanrob
force-pushed
the
wallet-ext-12-12
branch
3 times, most recently
from
7cd165d to
f2c50c6
Compare
rustaceanrob
force-pushed
the
wallet-ext-12-12
branch
from
f2c50c6 to
92ec239
Compare
ValuedMammal
approved these changes
Dec 16, 2024
|
|
||
| #[cfg(feature = "wallet")] | ||
| impl WalletExt for bdk_wallet::Wallet { | ||
| fn peek_revealed_plus_lookahead(&self) -> Box<dyn Iterator<Item = ScriptBuf>> { |
There was a problem hiding this comment.
I was wondering from an API perspective if this would make sense if implemented in bdk_wallet with a more abstract name, something like all_spks or just an iterator of all the derived addresses the wallet knows about including unrevealed. Then again, our peeking at the lookahead is somewhat off-label from the regular address API so probably better to leave it an extension trait.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.