Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add feature for rusqlite in kyoto #59

Merged
merged 1 commit into from
Sep 28, 2024
Merged

fix: add feature for rusqlite in kyoto #59

merged 1 commit into from
Sep 28, 2024

Conversation

rustaceanrob
Copy link
Collaborator

i was going to mess around with integrating bdk_kyoto into ldk-node and ran into an issue where two different sqlite libraries were being built. the rusqlite dependency in kyoto is not strictly necessary so i make it an optional dependency here

ValuedMammal
ValuedMammal approved these changes Sep 28, 2024
View reviewed changes
Copy link
Collaborator

@ValuedMammal ValuedMammal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 8b6d601

@rustaceanrob rustaceanrob merged commit e9ac942 into bitcoindevkit:master Sep 28, 2024
2 checks passed
@rustaceanrob rustaceanrob deleted the feature-09-27 branch September 28, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValuedMammal ValuedMammal ValuedMammal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rustaceanrob @ValuedMammal