Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CI actions to Node.js 20 #517

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update CI actions to Node.js 20 #517

wants to merge 1 commit into from

Conversation

thunderbiscuit
Copy link
Member

@thunderbiscuit thunderbiscuit commented Apr 29, 2024 •
edited
Loading

This fixes a number of warnings we're getting on CI runs.

Fixes #504

Unfortunately the scripts don't run as part of the PR so we can't tell if they error out directly, so I merged to my fork's master branch to run them there. You can see the runs here.

@thunderbiscuit thunderbiscuit requested a review from reez April 29, 2024 18:43
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Apr 29, 2024 •
edited
Loading

Walkthrough

The updates across various GitHub Actions workflow files primarily involve upgrading the actions/checkout and actions/setup-java to version 4. These changes are applied across multiple workflows that handle different aspects such as auditing, continuous integration, live testing, and publishing for different platforms including Android, JVM, and Python.

Changes

Files Changes
.github/workflows/audit.yml, .github/workflows/cont_integration.yml, .github/workflows/live-tests.yaml Updated actions/checkout from v3 to v4.
.github/workflows/publish-android.yaml, .github/workflows/publish-jvm.yaml, .github/workflows/publish-python.yaml Upgraded actions/checkout and actions/setup-java to v4.
.github/workflows/test-...yaml (covering Android, JVM, Python, Swift) Updated actions/checkout and actions/setup-java to v4.
Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between f31678b and 72c900f.
Files selected for processing (10)
  • .github/workflows/audit.yml (1 hunks)
  • .github/workflows/cont_integration.yml (2 hunks)
  • .github/workflows/live-tests.yaml (4 hunks)
  • .github/workflows/publish-android.yaml (2 hunks)
  • .github/workflows/publish-jvm.yaml (8 hunks)
  • .github/workflows/publish-python.yaml (9 hunks)
  • .github/workflows/test-android.yaml (2 hunks)
  • .github/workflows/test-jvm.yaml (2 hunks)
  • .github/workflows/test-python.yaml (8 hunks)
  • .github/workflows/test-swift.yaml (1 hunks)
Additional comments not posted (38)
.github/workflows/audit.yml (1)

20-20: Update to actions/checkout@v4 looks good.

Please ensure that the new version integrates well with the existing CI pipeline and does not introduce any regressions.

.github/workflows/test-swift.yaml (1)

19-19: Update to actions/checkout@v4 looks good.

Please ensure that the new version integrates well with the existing CI pipeline and does not introduce any regressions.

.github/workflows/test-jvm.yaml (2)

18-18: Update to actions/checkout@v4 looks good.

Please ensure that the new version integrates well with the existing CI pipeline and does not introduce any regressions.

30-30: Update to actions/setup-java@v4 looks good.

Please ensure that the new version integrates well with the existing CI pipeline and does not introduce any regressions.

.github/workflows/publish-android.yaml (2)

11-11: Update to actions/checkout@v4 looks good.

Please ensure that the new version integrates well with the existing CI pipeline and does not introduce any regressions.

23-23: Update to actions/setup-java@v4 looks good.

Please ensure that the new version integrates well with the existing CI pipeline and does not introduce any regressions.

.github/workflows/test-android.yaml (2)

23-23: Update to actions/checkout@v4 looks good.

Please ensure that the new version integrates well with the existing CI pipeline and does not introduce any regressions.

35-35: Update to actions/setup-java@v4 looks good.

Please ensure that the new version integrates well with the existing CI pipeline and does not introduce any regressions.

.github/workflows/cont_integration.yml (2)

24-24: Update to actions/checkout@v4 looks good.

Please ensure that the new version integrates well with the existing CI pipeline and does not introduce any regressions.

69-69: Update to actions/checkout@v4 looks good.

Please ensure that the new version integrates well with the existing CI pipeline and does not introduce any regressions.

.github/workflows/live-tests.yaml (3)

13-13: Update to actions/checkout@v4 looks good.

Please ensure that the new version integrates well with the existing CI pipeline and does not introduce any regressions.

48-48: Update to actions/checkout@v4 looks good.

Please ensure that the new version integrates well with the existing CI pipeline and does not introduce any regressions.

74-74: Update to actions/checkout@v4 looks good.

Please ensure that the new version integrates well with the existing CI pipeline and does not introduce any regressions.

.github/workflows/publish-jvm.yaml (9)

10-10: Update to actions/checkout@v4 looks good.

Please ensure that the new version integrates well with the existing CI pipeline and does not introduce any regressions.

22-22: Update to actions/setup-java@v4 looks good.

Please ensure that the new version integrates well with the existing CI pipeline and does not introduce any regressions.

39-39: Update to actions/upload-artifact@v4 looks good.

Please ensure that the new version integrates well with the existing CI pipeline and does not introduce any regressions.

49-49: Update to actions/checkout@v4 looks good.

Please ensure that the new version integrates well with the existing CI pipeline and does not introduce any regressions.

52-52: Update to actions/setup-java@v4 looks good.

Please ensure that the new version integrates well with the existing CI pipeline and does not introduce any regressions.

69-69: Update to actions/upload-artifact@v4 looks good.

Please ensure that the new version integrates well with the existing CI pipeline and does not introduce any regressions.

80-80: Update to actions/checkout@v4 looks good.

Please ensure that the new version integrates well with the existing CI pipeline and does not introduce any regressions.

92-92: Update to actions/setup-java@v4 looks good.

Please ensure that the new version integrates well with the existing CI pipeline and does not introduce any regressions.

118-118: Update to actions/upload-artifact@v4 looks good.

Please ensure that the new version integrates well with the existing CI pipeline and does not introduce any regressions.

.github/workflows/publish-python.yaml (8)

31-31: Updated actions/checkout to v4. Ensure that all dependent steps and configurations are compatible with this version.

47-47: Updated actions/upload-artifact to v4. Verify that the artifact paths and naming conventions remain functional with the new version.

68-68: Updated actions/checkout to v4 for macOS arm64 wheel builds. Check for any platform-specific issues with the new action version.

86-86: Updated actions/upload-artifact to v4 for macOS arm64 wheel builds. Confirm that the artifact upload process works as expected.

107-107: Updated actions/checkout to v4 for macOS x86_64 wheel builds. Ensure compatibility with macOS-specific configurations.

124-124: Updated actions/upload-artifact to v4 for macOS x86_64 wheel builds. Double-check the artifact path and naming.

145-145: Updated actions/checkout to v4 for Windows wheel builds. Validate that there are no issues with submodules on Windows.

159-159: Updated actions/upload-artifact to v4 for Windows wheel builds. Ensure that the Windows file path format is correctly handled.

.github/workflows/test-python.yaml (8)

40-40: Updated actions/checkout to v4. Confirm compatibility with the existing CI scripts and submodules configuration.

62-62: Updated actions/upload-artifact to v4. Ensure that the artifact upload process and path handling are correct.

83-83: Updated actions/checkout to v4 for macOS arm64 wheel builds. Check for any platform-specific issues with the new action version.

107-107: Updated actions/upload-artifact to v4 for macOS arm64 wheel builds. Confirm that the artifact upload process works as expected.

128-128: Updated actions/checkout to v4 for macOS x86_64 wheel builds. Ensure compatibility with macOS-specific configurations.

150-150: Updated actions/upload-artifact to v4 for macOS x86 64 wheel builds. Double-check the artifact path and naming.

171-171: Updated actions/checkout to v4 for Windows wheel builds. Validate that there are no issues with submodules on Windows.

187-187: Updated actions/upload-artifact to v4 for Windows wheel builds. Ensure that the Windows file path format is correctly handled.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@thunderbiscuit thunderbiscuit removed the request for review from reez April 29, 2024 19:00
@thunderbiscuit
Copy link
Member Author

Darn the Python manylinux OS based runs fail. I'll need to take a closer look and see if we can install manually the required glibc library version, or something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI Action Warning
1 participant
@thunderbiscuit