-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Rust compiler to 1.73.0 and update uniffi to 0.25.1 #414
Bump Rust compiler to 1.73.0 and update uniffi to 0.25.1 #414
Conversation
9df7881
to
48c8e72
Compare
48c8e72
to
fc4240c
Compare
I have tested the library locally on a version of the Devkit Wallet. This is a fairly important update across 3 different dimensions; happy to report that everything seems to work well. |
5c81af8
to
f2cd561
Compare
I was able to build the bdk-swift library locally ( I then tested the library locally on a simplified version of BDKSwiftExampleWallet, able to create the wallet and sync the balance properly, so seems to be working well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK f2cd561
ACK f2cd561 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I confirmed that we can also easily upgrade LDK Node to Uniffi 0.25.1 (see lightningdevkit/ldk-node#190) and bindings interop should at least not be blocked on version mismatch. Thanks for checking in!
This PR fixes a number of longstanding issues with uniffi, the Rust compiler, and the Android NDK. In short, it updates all 3 to new versions:
Fixes #413
Fixes #243
Fixes #242
Will help get #282 in.
We have two main reasons for bumping the uniffi version:
And one reason to bump the NDK: