Skip to content

Commit

Permalink
add validate domain option to electrum
Browse files Browse the repository at this point in the history
This has been added to bdk in

bitcoindevkit/bdk@8d4cc39
  • Loading branch information
dspicher committed Jun 9, 2023
1 parent eef97ad commit c6c44e1
Showing 1 changed file with 13 additions and 1 deletion.
14 changes: 13 additions & 1 deletion src/commands.rs
Original file line number Diff line number Diff line change
Expand Up @@ -320,6 +320,10 @@ pub struct ElectrumOpts {
default_value = "10"
)]
pub stop_gap: usize,

/// Enable domain validation when connecting to Electrum servers.
#[clap(name = "VALIDATE_DOMAIN", long = "validate_domain")]
pub validate_domain: bool,
}

/// Options to configure Esplora backend.
Expand Down Expand Up @@ -663,6 +667,7 @@ mod test {
timeout: None,
server: "ssl://electrum.blockstream.info:60002".to_string(),
stop_gap: 10,
validate_domain: false,
},
#[cfg(feature = "esplora")]
esplora_opts: EsploraOpts {
Expand Down Expand Up @@ -707,6 +712,7 @@ mod test {
"--change_descriptor", "wpkh(tpubDEnoLuPdBep9bzw5LoGYpsxUQYheRQ9gcgrJhJEcdKFB9cWQRyYmkCyRoTqeD4tJYiVVgt6A3rN6rWn9RYhR9sBsGxji29LYWHuKKbdb1ev/1/*)",
"--server","ssl://electrum.blockstream.info:50002",
"--stop_gap", "20",
"--validate_domain",
"get_new_address"];

let cli_opts = CliOpts::from_iter(&cli_args);
Expand All @@ -723,7 +729,8 @@ mod test {
electrum_opts: ElectrumOpts {
timeout: Some(10),
server: "ssl://electrum.blockstream.info:50002".to_string(),
stop_gap: 20
stop_gap: 20,
validate_domain: true,
},
proxy_opts: ProxyOpts{
proxy: Some("127.0.0.1:9150".to_string()),
Expand Down Expand Up @@ -927,6 +934,7 @@ mod test {
timeout: None,
server: "ssl://electrum.blockstream.info:60002".to_string(),
stop_gap: 10,
validate_domain: false,
},
#[cfg(feature = "esplora")]
esplora_opts: EsploraOpts {
Expand Down Expand Up @@ -1006,6 +1014,7 @@ mod test {
timeout: None,
server: "ssl://electrum.blockstream.info:60002".to_string(),
stop_gap: 10,
validate_domain: false,
},
#[cfg(feature = "esplora")]
esplora_opts: EsploraOpts {
Expand Down Expand Up @@ -1078,6 +1087,7 @@ mod test {
timeout: None,
server: "ssl://electrum.blockstream.info:60002".to_string(),
stop_gap: 10,
validate_domain: false,
},
#[cfg(feature = "esplora")]
esplora_opts: EsploraOpts {
Expand Down Expand Up @@ -1149,6 +1159,7 @@ mod test {
timeout: None,
server: "ssl://electrum.blockstream.info:60002".to_string(),
stop_gap: 10,
validate_domain: false,
},
#[cfg(feature = "esplora")]
esplora_opts: EsploraOpts {
Expand Down Expand Up @@ -1486,6 +1497,7 @@ mod test {
timeout: None,
server: "ssl://electrum.blockstream.info:60002".to_string(),
stop_gap: 10,
validate_domain: false,
},
},
};
Expand Down

0 comments on commit c6c44e1

Please sign in to comment.