add validate domain option to electrum

This has been added to bdk in bitcoindevkit/bdk@8d4cc39
bitcoindevkit · Jun 27, 2023 · 470464d · 470464d
1 parent eef97ad
commit 470464d
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,7 @@ Changelog info is also documented on the [GitHub releases](https://github.com/bi
 page. See [DEVELOPMENT_CYCLE.md](DEVELOPMENT_CYCLE.md) for more details.
 
 ## [Unreleased]
+- Added the `validate_domain` option to Electrum arguments.
 
 ## [0.27.1]
 - Added hardware signers through the use of HWI.

diff --git a/src/commands.rs b/src/commands.rs
@@ -320,6 +320,10 @@ pub struct ElectrumOpts {
         default_value = "10"
     )]
     pub stop_gap: usize,
+
+    /// Enable domain validation when connecting to Electrum servers [default: true].
+    #[clap(name = "VALIDATE_DOMAIN", long = "validate_domain")]
+    pub validate_domain: Option<bool>,
 }
 
 /// Options to configure Esplora backend.
@@ -663,6 +667,7 @@ mod test {
                         timeout: None,
                         server: "ssl://electrum.blockstream.info:60002".to_string(),
                         stop_gap: 10,
+                        validate_domain: None,
                     },
                     #[cfg(feature = "esplora")]
                     esplora_opts: EsploraOpts {
@@ -707,6 +712,7 @@ mod test {
                             "--change_descriptor", "wpkh(tpubDEnoLuPdBep9bzw5LoGYpsxUQYheRQ9gcgrJhJEcdKFB9cWQRyYmkCyRoTqeD4tJYiVVgt6A3rN6rWn9RYhR9sBsGxji29LYWHuKKbdb1ev/1/*)",
                             "--server","ssl://electrum.blockstream.info:50002",
                             "--stop_gap", "20",
+                            "--validate_domain", "false",
                             "get_new_address"];
 
         let cli_opts = CliOpts::from_iter(&cli_args);
@@ -723,7 +729,8 @@ mod test {
                     electrum_opts: ElectrumOpts {
                         timeout: Some(10),
                         server: "ssl://electrum.blockstream.info:50002".to_string(),
-                        stop_gap: 20
+                        stop_gap: 20,
+                        validate_domain: Some(false),
                     },
                     proxy_opts: ProxyOpts{
                         proxy: Some("127.0.0.1:9150".to_string()),
@@ -927,6 +934,7 @@ mod test {
                         timeout: None,
                         server: "ssl://electrum.blockstream.info:60002".to_string(),
                         stop_gap: 10,
+                        validate_domain: None,
                     },
                     #[cfg(feature = "esplora")]
                     esplora_opts: EsploraOpts {
@@ -1006,6 +1014,7 @@ mod test {
                         timeout: None,
                         server: "ssl://electrum.blockstream.info:60002".to_string(),
                         stop_gap: 10,
+                        validate_domain: None,
                     },
                     #[cfg(feature = "esplora")]
                     esplora_opts: EsploraOpts {
@@ -1078,6 +1087,7 @@ mod test {
                         timeout: None,
                         server: "ssl://electrum.blockstream.info:60002".to_string(),
                         stop_gap: 10,
+                        validate_domain: None,
                     },
                     #[cfg(feature = "esplora")]
                     esplora_opts: EsploraOpts {
@@ -1149,6 +1159,7 @@ mod test {
                         timeout: None,
                         server: "ssl://electrum.blockstream.info:60002".to_string(),
                         stop_gap: 10,
+                        validate_domain: None,
                     },
                     #[cfg(feature = "esplora")]
                     esplora_opts: EsploraOpts {
@@ -1486,6 +1497,7 @@ mod test {
                     timeout: None,
                     server: "ssl://electrum.blockstream.info:60002".to_string(),
                     stop_gap: 10,
+                    validate_domain: None,
                 },
             },
         };

diff --git a/src/utils.rs b/src/utils.rs
@@ -400,7 +400,7 @@ pub(crate) fn new_blockchain(
             retry: wallet_opts.proxy_opts.retries,
             timeout: wallet_opts.electrum_opts.timeout,
             stop_gap: wallet_opts.electrum_opts.stop_gap,
-            validate_domain: true,
+            validate_domain: wallet_opts.electrum_opts.validate_domain.unwrap_or(true),
         })
     };