-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make '-min' minimize wallet loading dialog #749
Conversation
When '-min' is enabled, no loading dialog should be presented on screen during startup.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested this change. Created several wallets in order to see the "Loading wallet..." dialog for a while.
Without your change in master when I run bitcoin-qt -min
the dialog is not shown and the app opens as usual.
With your change when I run bitcoin-qt -min
, the app gets minimized entirely, is that intentional?
Yes. Thats the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 32db154, tested on Debian 11 + XFCE.
The bug did not reveal itself on my Ubuntu + GNOME.
FWIW, a user on #bitcoin IRC mentioned today that this patch wasn't backported to v25.x. |
Simple fix for #748.
When '-min' is enabled, no loading dialog should
be presented on screen during startup.