Jade pip api and native psbt #763
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamieDriver
force-pushed
the
jade_pip_api_and_native_psbt
branch
from
f8d5edb to
2d96b1f
Compare
JamieDriver
changed the title
JamieDriver
force-pushed
the
jade_pip_api_and_native_psbt
branch
from
2d96b1f to
2fab146
Compare
|
Hi, |
JamieDriver
force-pushed
the
jade_pip_api_and_native_psbt
branch
from
2fab146 to
28c4e8d
Compare
|
NACK We prefer to pull in vendor libraries to have better control over dependencies and to be able to remove things that we do not wish to support. In this particular case, that would be the bluetooth stuff. |
|
The pip install does not include the 'Bluetooth stuff' ! But ok, if you prefer to include a copy of the lib code, I'll revisit #753. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of
1.0.32, the jade-client (jadepy) is available on PyPi and so can bepip install-ed, and we can remove the local copy of the code.If preferred, this can supersede #753