Add copy url #4
Open
Add copy url #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bit2pixel - i just realised i didn't sync my fork before working on this. Basically, the only lines you'd need are in chrome.js#L189-L203 and adding the modifiers again (i'm currently using the setup like in the screenshots below)
The You can clearly close this PR and just attach the copy function and the flow to the workflow yourself, -- tagging a new release maybe so that i can pull it in too ?:) |
|
hi @bit2pixel - i realise you must be busy but have you had the chance to look at this ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the copy functionality.
The workflow that exists in this repo, also allows for a modifier key (shift) to enable a secondary action that allows the copy of the selected (from the list) tab's URL directly to the clipboard.
This also addresses #2 :)