Fixed PointOfInterest template and added openUrl #153
Conversation
|
Very nice! Thank you for the contribution. |
|
We are getting lockfile conflict because of "react-native": "" and "react": "" Any reason for the change?
Once tests pass I'll merge! |
|
@birkir Have you merged this changes? If not kindly merge those changes. Stuck on POI Template. |
It's not ready as far as I'm concerned. |
|
@birkir Ohh, Okay. I'm waiting for this update. Its blocking me to proceed further. Can you give any possible way to use POI for now? |
|
You can easily apply patches to any packages if you want. Feel free to use changes from this PR |
|
@blanck still seeing the unsupported object issue |
| @@ -92,6 +93,7 @@ + (id)allocWithZone:(NSZone *)zone { | |||
| @"albumArtistButtonPressed", | |||
| // poi | |||
| @"didSelectPointOfInterest", | |||
| @"didChangeMapRegion", | |||
There was a problem hiding this comment.
Could we apply this only in another PR?
PointOfInterest template has been updated with:
Parameters
Actions
Events
OpenURL method added
Store and connect controller updated to include scene. Required to enable openUrl function to open other apps from an action button. Example to open a navigation app (Maps, Google Maps, Waze) and navigate to a POI.
Example code:
const url = 'maps://?q=London&ll=51.5074256%2C-0.1271814'; CarPlay.openUrl(url);