Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! First off, nice library, it looks great.
We used this for a hackathon for our app to implement stories, and we discovered a few issues, so I hope it's OK that I'm opening a PR with some suggestions for fixes.
I might also have a few UX suggestions/features/refactors that I will suggest in future PRs/issues.
This PR fixes the following:
pointerEvents="box-none"
on the content view.onImageChange
: when going back to the previous user, the "progress" animation is always reset, but sometimes the image does not change. This is caused by theactive
state not always being true before theactiveStory
state changes. I fixed this by removing the early return ifactive.value
is not true. I don't think this check is necessary, since we return immediately after if the story matching theactiveStory
is not found.