Independent of eggshell #317
Conversation
| @@ -0,0 +1,167 @@ | |||
| .. tutorial | |||
|
|
|||
| Tutorials | |||
There was a problem hiding this comment.
I suggest converting this into a notebook (for example docs/source/notebooks/subset.ipynb).
There was a problem hiding this comment.
@huard
to centralise notebooks they are a notebook repository:
https://github.com/bird-house/notebooks
Perfer to have the docs in rst format to avoid unecessary downloads.
I included the link to the original notebook to open optionally.
There was a problem hiding this comment.
How do you make sure that the rst file is in sync with the code ? Ie that it does not become outdated ?
There was a problem hiding this comment.
@huard
Will answer here: bird-house/notebooks#2
environment.yml
Outdated
| @@ -30,6 +30,6 @@ dependencies: | |||
| ############## | |||
| # pip install | |||
| - pip: | |||
| - -e git+https://github.com/bird-house/eggshell.git#egg=eggshell | |||
| # - -e git+https://github.com/bird-house/eggshell.git#egg=eggshell | |||
| - -e git+https://github.com/NCPP/ocgis#egg=owslib | |||
There was a problem hiding this comment.
The pypi release should be fine.
There was a problem hiding this comment.
instead of
ocgis#egg=owslib
use
ocgis#egg=ocgis
but using released package resolves this.
flyingpigeon/calculation.py
Outdated
| @@ -0,0 +1,290 @@ | |||
| from flyingpigeon.nc_utils import get_values, get_coordinates, get_index_lat, get_variable | |||
There was a problem hiding this comment.
calculation.py is not very specific.
There was a problem hiding this comment.
it included fieldmean, climate change signal calculation, would be the place for robustness, bias, trend substractions etc ...
may be values_statistic is better or nc_statistic?
environment.yml
Outdated
| @@ -30,6 +30,6 @@ dependencies: | |||
| ############## | |||
| # pip install | |||
| - pip: | |||
| - -e git+https://github.com/bird-house/eggshell.git#egg=eggshell | |||
| # - -e git+https://github.com/bird-house/eggshell.git#egg=eggshell | |||
| - -e git+https://github.com/NCPP/ocgis#egg=owslib | |||
There was a problem hiding this comment.
instead of
ocgis#egg=owslib
use
ocgis#egg=ocgis
but using released package resolves this.
Overview
This PR fixes [316] and [302]
Changes:
functions from eggshell moved back to flyingpigeon.
add a tutorial based on:
https://github.com/bird-house/notebooks/blob/master/flyingpigeon_birdy_subset.ipynb