Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cftime bug, no fail on pip check, pin xarray/pandas #322

Merged
merged 8 commits into from
Dec 5, 2023
Merged

Fix cftime bug, no fail on pip check, pin xarray/pandas #322

merged 8 commits into from
Dec 5, 2023

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Dec 4, 2023 •
edited
Loading

Overview

Changes:

  • Added pins to xarray and pandas to prevent issues with breaking changes.
  • Fixed an error with a cftime index fixing function.
  • Switched bump2version for bump-my-version
  • Do not fail when running pip check in conda environments

Related Issue / Discussion

Ouranosinc/xclim#1534
pydata/xarray#8394

@Zeitsperre Zeitsperre self-assigned this Dec 4, 2023
@Zeitsperre
Copy link
Collaborator Author

This needs a pin on xarray to deal with the cftime issue.

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Dec 5, 2023
@Zeitsperre Zeitsperre changed the title No fail on pip check Fix cftime bug, no fail on pip check, pin xarray/pandas Dec 5, 2023
@Zeitsperre Zeitsperre merged commit 710150f into master Dec 5, 2023
8 of 9 checks passed
@Zeitsperre Zeitsperre deleted the no-fail-pip-check branch December 5, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlogan2000 tlogan2000 tlogan2000 approved these changes

@aulemahal aulemahal Awaiting requested review from aulemahal

Assignees

@Zeitsperre Zeitsperre

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zeitsperre @tlogan2000