Test notebooks with --nbval-lax

[huard]

Overview

This PR fixes #105

Changes:

• Use --nbval-lax instead of --nbval in make test-notebooks

This is untested.
Is there a way to run make commands on the generated repo in the test suite ?

[tlvu]

Is there a way to run make commands on the generated repo in the test suite ?

How I test cookiecutter changes is I have a personal clone of this cookiecutter repo and I point cruft to my fork ... then I have to revert before final merge.

But for this change, it's too simple, you just go into one of the generated repo (Finch, Raven, ... ) and make the same change manually.

[tlvu]

That said, I've been thinking over about this and can we try to keep the current behavior to check cell output and then use # NBVAL_IGNORE_OUTPUT for cells that can not be validated, even with sanitize regex (our sanitize regex is getting pretty complete now)? Honestly there is nothing that fail currently (Finch, Pavics-sdi).

The last Finch failure is because the server side actually need to be updated. I'd say it was good that we are forced to deploy the newer Finch. We've been too lax in keeping the deployed server side up-to-date.

We've been thinking about disabling output checking because of Xarray html dataset output. Not every cell will display Xarray so I don't feel it justified to disable all checks just for some Xarray cells.

[cehbrecht]

That said, I've been thinking over about this and can we try to keep the current behavior to check cell output

maybe add nbval-lax as a new target in the Makefile to have this test in addition (test-notebooks-lax)?

[Zeitsperre]

Addressed by #116