Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for space group information when reading and writing pdb files #707

Merged
merged 10 commits into from
Dec 22, 2024

Conversation

alex-sbaq
Copy link
Contributor

Added get_space_group() and set_space_group() methods as discussed in #689 to support space group and Z value reading/writing for (deprecated) PDB files.

@alex-sbaq alex-sbaq marked this pull request as ready for review November 27, 2024 13:42
Copy link
Member

@padix-key padix-key left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for implementing this functionality! Could you add a test as well to tests/structure/io/test_pdb.py? I think something analogous to test_conversion() would work well here: Setting and subsequent retrieving of the space group should return the original space group.

src/biotite/structure/io/pdb/file.py Outdated Show resolved Hide resolved
src/biotite/structure/io/pdb/file.py Outdated Show resolved Hide resolved
src/biotite/structure/io/pdb/file.py Outdated Show resolved Hide resolved
src/biotite/structure/io/pdb/file.py Outdated Show resolved Hide resolved
src/biotite/structure/io/pdb/file.py Outdated Show resolved Hide resolved
Copy link

codspeed-hq bot commented Nov 29, 2024

CodSpeed Performance Report

Merging #707 will not alter performance

Comparing alex-sbaq:pdb_space_group (ded3998) with main (2765f4b)

Summary

✅ 47 untouched benchmarks

@alex-sbaq alex-sbaq requested a review from padix-key December 5, 2024 18:14
@padix-key
Copy link
Member

Thanks for the update! I will give the PR a final review on the weekend.

Copy link
Member

@padix-key padix-key left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test. I have some minor requests for it, but otherwise, everything looks good!

tests/structure/io/test_pdb.py Outdated Show resolved Hide resolved
alex-sbaq and others added 2 commits December 20, 2024 09:10
Code conciseness updates

Co-authored-by: Patrick Kunzmann <[email protected]>
@alex-sbaq alex-sbaq requested a review from padix-key December 20, 2024 17:06
@alex-sbaq
Copy link
Contributor Author

Thanks for the feedback, @padix-key! I've made the changes to the test - let me know if anything is missing.

Copy link
Member

@padix-key padix-key left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the PR looks good to me. I will just wait for the CI to see if the tests pass

@padix-key padix-key merged commit 8ad4856 into biotite-dev:main Dec 22, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants