Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly cache semanticType (fix undefined categories out of cache) #25

Merged
merged 3 commits into from
Aug 9, 2021

Conversation

tokebe
Copy link
Member

@tokebe tokebe commented Aug 6, 2021

(fixes biothings/biothings_explorer#234)

This change causes cache_handler to copy the semanticType of input/output nodes while copying records from a query response. When pulled from the cache, these values are read to give each kg node a category. Previously, none would be found and categories would become biolink:undefined.

Example query (test with caching enabled):

{
  "message": {
    "query_graph": {
      "nodes": {
        "n0": {
          "categories": [
            "biolink:Disease"
          ]
        },
        "n1": {
          "ids": [
            "HGNC:6284"
          ],
          "categories": [
            "biolink:Gene"
          ]
        }
      },
      "edges": {
        "e0": {
          "subject": "n0",
          "object": "n1"
        }
      }
    }
  }
}

@newgene newgene merged commit 344aabd into main Aug 9, 2021
@colleenXu colleenXu deleted the fix_bte_trapi_234 branch October 25, 2023 20:08
@colleenXu colleenXu restored the fix_bte_trapi_234 branch October 25, 2023 20:09
@tokebe tokebe deleted the fix_bte_trapi_234 branch November 29, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

biolink:undefined on node categories
2 participants