Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do pfocr for creative/pathfinder mode at the end #217

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Conversation

rjawesome
Copy link
Contributor

@rjawesome rjawesome commented Sep 16, 2024

biothings/biothings_explorer#847. Runs PFOCR augmentation after all creative results have been created.

@colleenXu
Copy link
Contributor

Will this work with Pathfinder too (pathfinder-newsystem branch I guess)?

Also can you adjust the "development" tab in github so merging this PR won't close the issue?

@rjawesome
Copy link
Contributor Author

rjawesome commented Sep 16, 2024

@colleenXu
Currently, pathfinder does not add PFOCR figures. However, I have just added a commit to this PR that should add PFOCR to pathfinder results (should work for any pathfinder branch).
(also the "development" tab for the issue should be fixed)

@rjawesome rjawesome changed the title do pfocr for creative mode at the end do pfocr for creative/pathfinder mode at the end Sep 16, 2024
@colleenXu
Copy link
Contributor

Hmmm while running Pathfinder queries, I noticed that PFOCR result-augmentation would happen at the end of each template...which added time to execution.

I think It's good that you adjusted things so PFOCR result-augmentation only runs on pathfinder results at the end (another option is to make it so it doesn't run at all).

@tokebe tokebe added the On Dev Related changes are deployed to Dev server label Sep 17, 2024
Copy link
Member

@tokebe tokebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR fails to build because it requires that the QueryHandlerOptions type be amended in packages/types/src/tasks.ts

@tokebe tokebe removed the On Dev Related changes are deployed to Dev server label Sep 17, 2024
@rjawesome
Copy link
Contributor Author

@tokebe Oops, I forgot to make a PR for that. See biothings/biothings_explorer#869

@colleenXu colleenXu added the On Dev Related changes are deployed to Dev server label Sep 18, 2024
@tokebe tokebe merged commit 4218b96 into main Sep 26, 2024
0 of 2 checks passed
@tokebe tokebe added On CI Related changes are deployed to CI server and removed On Dev Related changes are deployed to Dev server labels Sep 26, 2024
@colleenXu colleenXu added On CI -> Test Related changes are on CI server, pending Test deployment and removed On CI Related changes are deployed to CI server labels Oct 24, 2024
@tokebe tokebe added On Test Related changes are deployed to Test server and removed On CI -> Test Related changes are on CI server, pending Test deployment labels Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On Test Related changes are deployed to Test server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants