-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do pfocr for creative/pathfinder mode at the end #217
Conversation
Will this work with Pathfinder too ( Also can you adjust the "development" tab in github so merging this PR won't close the issue? |
@colleenXu |
Hmmm while running Pathfinder queries, I noticed that PFOCR result-augmentation would happen at the end of each template...which added time to execution. I think It's good that you adjusted things so PFOCR result-augmentation only runs on pathfinder results at the end (another option is to make it so it doesn't run at all). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR fails to build because it requires that the QueryHandlerOptions
type be amended in packages/types/src/tasks.ts
@tokebe Oops, I forgot to make a PR for that. See biothings/biothings_explorer#869 |
biothings/biothings_explorer#847. Runs PFOCR augmentation after all creative results have been created.