Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up intersectWithExpandedCuries #182

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Speed up intersectWithExpandedCuries #182

merged 1 commit into from
Mar 7, 2024

Conversation

rjawesome
Copy link
Contributor

When testing a query on my computer, the function went from around 9000ms to 30ms

The speedup is achieved through two main methods:

  • Using a set to lookup expanded curie, instead of two loops
  • Switching loop functions such as forEach to use for loops instead

@tokebe tokebe merged commit 559de80 into main Mar 7, 2024
0 of 2 checks passed
@tokebe tokebe added On CI Related changes are deployed to CI server On Test Related changes are deployed to Test server and removed On CI Related changes are deployed to CI server labels Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
On Test Related changes are deployed to Test server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rjawesome @tokebe