-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
semmed sentence edge attributes #68
Conversation
Is this ready for testing? The linked issue isn't in the "Awaiting Review" column... Also, on "subject/object location can be supported"....
|
I wanted to do a basic test (which would require me to modify the smartapi yaml to ingest the edge attributes). Hopefully I can complete that today and then mark it for review.
Yes, but this won't work until the smartapi yaml is updated to request the subject_text and object_text fields from the SemmedDB BioThings API (otherwise it throws an error since those fields are missing).
Correct. |
@colleenXu In addition to requesting |
(1) I originally proposed using Is there a reason you went with
(2) In my original proposal and this branch, I changed |
(1) We can keep ie. edge-attributes would contain something like this
(2) I missed the branch on the translator registry repo. That covers all the predication fields, however, the changes to get the edge-attributes are still needed. |
Sorry for the delay in testing. It looks good except for 1 thing: it's not respecting the edge max limit of 50 unique sentences/publications, aka only make 50 of these special edge-attributes. Could there be a problem when multiple records get merged into 1 edge? You can use the translator-api-registry branch I've made. The response-mapping should match Rohan's specs now. Example
add to override: Query:
Look at edge Other examples are:
|
I'll try to take a look at it this week. |
@colleenXu The amount of publications in the Semmed edge attributes should be capped at 50 now (the max edge attributes in the example decreases to 53) |
I've tested using the latest main branches + this PR + biothings/bte-server#45. I think this is ready to put onto CI for testing this weekend... |
biothings/biothings_explorer#833
Needs semmedb's response mapping to ingest the edge attributes.
aka, add the following to all response mappings
Can also support saying subject/object location, if subject/object text is retrieved from the semmed api as a field