Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue pipeline 387 - add GAF header information to aggregated GPAD produced by megamake step (aka. ontobio/bin/validate.py) #698

Merged
merged 6 commits into from
Dec 9, 2024
Merged

Issue pipeline 387 - add GAF header information to aggregated GPAD produced by megamake step (aka. ontobio/bin/validate.py) #698

merged 6 commits into from
Dec 9, 2024

Conversation

sierra-moxon
Copy link
Member

@sierra-moxon sierra-moxon commented Nov 12, 2024 •
edited
Loading

dustine32
dustine32 approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@dustine32 dustine32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass and I think I like how the write-out is now separated from the process_[gaf|gpad]... functions now.

@sierra-moxon sierra-moxon merged commit 103cbcd into master Dec 9, 2024
2 checks passed
@sierra-moxon sierra-moxon mentioned this pull request Dec 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustine32 dustine32 dustine32 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sierra-moxon @dustine32