-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go site 676 gorule 0000022 check for retracted publications #674
Go site 676 gorule 0000022 check for retracted publications #674
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mugitty These changes generally make sense to me.
Looking at this, one thing we had discussed was making the use of retracted publications completely optional--i.e. adding a new option to the path and only executing if available. It looks like this just depends on the go-site metadata directory? We would like to be able to turn these on/off, switch targets, etc.; it looks like it errors out on file not existing now?
@mugitty It looks like the test error:
is related to the handling of go-site metadata as mentioned above. |
@kltm , I did not realized that we wanted a flag to determine if the test should be run. So, it would only be in ontobio-parse-assocs.py as a parameter? For the error, is it expecting set[] instead of set[str] due to version of python? |
@mugitty For me, I just want to make sure that the file is optional, and ideally be able to specify it in different contexts. The exact mechanism isn't too too important. |
Linking to issue geneontology/go-site#676 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Examining code, it looks like:
- if file given, rule run
- if file found at assumed location, rule run
- otherwise, rule skipped
I believe this is in line with what we discussed; if so, please merge at your convenience
No description provided.