Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace prefixcommons usages with curies #472

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

cthoyt
Copy link

@cthoyt cthoyt commented Nov 5, 2023

This PR replaces usages of prefixcommons with curies. This is the first step towards more principled management of I/O of prefix maps that has the following benefits:

  1. Prefix map chaining is done using a tested and well-defined algorithm curies.chain
  2. Compression uses a fast and correct Trie data structure
  3. We replace the internal implementation of expansion and compression with a well-tested one

Next steps after this PR will be to replace the usage of the contract and expand functions directly using curies.Converter, which will have a massive speed gain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant