eliminate a potential bug #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
example is already an instance class, this code may result in a error of "** is unknow and can't be cast into float" becuase example is a list of instance.
| @@ -264,7 +264,7 @@ def __call__(self, example, result_type=Orange.core.GetValue): | |||
| :rtype: :class:`Orange.data.Value`, | |||
| :class:`Orange.statistics.Distribution` or a tuple with both | |||
| """ | |||
| example = Orange.data.Instance(self.domain, example) | |||
| #example = Orange.data.Instance(self.domain, example) | |||
There was a problem hiding this comment.
If the line is at fault, why not just delete it? 😃
There was a problem hiding this comment.
@kernc yeah, it should be deleted I think. It was added by @ales-erjavec and I was not sure whether it is necessary in some cases. When I was using NN node to validate a test set, I found that the 'example' is a list of orange object which can't be cast into float. I don't know about the class of instance. It worked after I commented it refering to an old version.
There was a problem hiding this comment.
Well, if you propose to fix the bug by deleting the line, then delete it. Don't just comment it out for posterity to wonder what's it really all about when the answer is (may be) nothing. 😃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
example is already an instance class, this code may result in a error of "** is unknow and can't be cast into float" occurs in line 271.