Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New/image worker interface #590

Closed

Conversation

Rui-Jesus
Copy link
Collaborator

This PR introduces a new interface to Dicoogle to request directly image services from plugins, instead of using a rest plugin.

This work will serve as a base for an upcoming task to integrate image analysis services in Dicoogle.

Key changes:

  • New image worker interface
  • Integration of new interface in plugin manager
  • New data structs to manage image rois

Copy link
Collaborator

@Enet4 Enet4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. However, we need to put this on hold until the following key points are settled:

  • What exactly is being proposed here? Technical issues aside, ImageWorkerInterface is insufficiently documented and I cannot infer much from its definition.
  • What are the general use cases solved by having this plugin interface? What would be a possible implementation, and does the interface make sense beyond the one presented?
  • What added benefits do we have when incorporating this into the SDK? What can the core project do to integrate these plugins and provide value to the archive as a whole?

As this is part of a bigger plan to support image analysis, it may help to disclose what the subsequent steps would be.

@Rui-Jesus
Copy link
Collaborator Author

Thank you for your contribution. However, we need to put this on hold until the following key points are settled:

  • What exactly is being proposed here? Technical issues aside, ImageWorkerInterface is insufficiently documented and I cannot infer much from its definition.
  • What are the general use cases solved by having this plugin interface? What would be a possible implementation, and does the interface make sense beyond the one presented?
  • What added benefits do we have when incorporating this into the SDK? What can the core project do to integrate these plugins and provide value to the archive as a whole?

As this is part of a bigger plan to support image analysis, it may help to disclose what the subsequent steps would be.

Yeah you're out of the loop for this feature, it has been discussed for some with @bastiao.
This is a WIP and improvements are welcome. This PR is not meant to be final, but I put it up because another contribution (private plugin) needs these updates.

For the moment this is needed for the iPATH project. The problem is that we needed a way to request ROIs from WSI to feed image analysis algorithms. A REST plugin would suffice, but another WIP (branch new/machine-learning-provider from BMD fork) has work in progress for the implementation of a new interface for Image Analysis providers. In this contribution there was a need to process images in core (for the moment, only ROI extraction, but more features are expected) and working with REST plugins was inconvenient, so this new interface was created.

This is the main idea:
image

I suggest we discuss better in a meeting.

@Enet4 Enet4 marked this pull request as draft July 4, 2022 11:14
@Rui-Jesus Rui-Jesus force-pushed the new/image-worker-interface branch from 7a55144 to f0e92a8 Compare November 19, 2022 18:12
@Rui-Jesus
Copy link
Collaborator Author

This PR is being closed, the work was migrated here: #631

@Rui-Jesus Rui-Jesus closed this Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants