Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language Option, Relevance Score, #158

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

WagnerJon
Copy link

  • added option to choose the prefered language query in the benchmark_data.yaml
  • added relevance score
  • added test function with reassurance

unsure about the implementation of these things

WagnerJon added 4 commits June 3, 2024 16:18
added option to choose language for benchmarks
added relevance score
- added additional language option
upload of newer results
@slobentanzer
Copy link
Contributor

TODO:

  • move end-to-end query generation to query generation only (use method _generate_query)
  • use dedicated query_language parameter in _generate_query() method (remove string engineering from test)
  • check rag_interpretation tests to reuse the evaluation_conversation fixture (contest.py)

@slobentanzer slobentanzer marked this pull request as draft July 24, 2024 15:01
@slobentanzer
Copy link
Contributor

@WagnerJon you opened a new PR #225, should this one be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants